Fix thread-safety race condition in processSchemaInfo#205
Open
EzRyan25 wants to merge 1 commit into
Open
Conversation
…when finished. processSchemaInfo() in entity.py first assigns the global _rally_schema var indexed at wksp_ref to and empty dict, wiping out previous built schema data when there could be other instances of pyral processing stories in your application making this not thread safe as threads share this global var. Instead build schema info into local dict and assign to global var when finished
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processSchemaInfo in entity.py wipes _rally_schema[wksp_ref] at the start of execution and rebuilds it incrementally. In multi-threaded applications with multiple Rally() instances sharing the same workspace, a concurrent thread reading _rally_schema during this window receives None from getSchemaItem, causing validateAttributeNames to crash with AttributeError: 'NoneType' object has no attribute 'Attributes'.
This PR fixes the race by building the schema into a local dict and performing a single atomic assignment at the end, so the shared global is never in an empty or partial state.