Skip to content

fix(netdev): 修复无网卡时 ping 命令空指针崩溃 #11756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Huoyanlifusu wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(netdev): 修复无网卡时 ping 命令空指针崩溃 #11756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions components/net/netdev/src/netdev.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1340,6 +1340,11 @@ int netdev_cmd_ping(char* target_name, char *netdev_name, rt_uint32_t times, rt_
if (netdev == RT_NULL)
{
netdev = netdev_default;
if (netdev == RT_NULL)
{
rt_kprintf("ping: not found default netif, please specify netdev name.\n");
return -RT_ERROR;
}
rt_kprintf("ping: not found specified netif, using default netdev %s.\n", netdev->name);
}

Expand Down Expand Up @@ -1412,6 +1417,12 @@ int netdev_cmd_ping(char* target_name, char *netdev_name, rt_uint32_t times, rt_
rt_thread_delay(delay_tick);
}

if (times == 0)
{
rt_kprintf("ping: send times is zero, no ping statistics.\n");
return -RT_ERROR;
}

/* print ping statistics */
loss = (uint32_t)((1 - ((float)received) / index) * 100);
avg_time = (uint32_t)(avg_time / received);
Expand Down
Loading