[NO CP][release/2.8][ROCm][inductor] Inductor heuristic upstream backports#3006
Merged
jataylo merged 3 commits intorelease/2.8from Mar 6, 2026
Merged
Conversation
…ports (#2807) These are backports based on these upstream PRs. Cherrypicks were performed when they where possible. pytorch#163908 (persistent reduction autotune) pytorch#161280 (reduction) pytorch#162053 (foreach) pytorch#163197 (pointwise) pytorch#166470 (pointwise config for atomic add) Also included are some additional customer-specific configs which were not upstreamed but are in this backport to 2.9 #2723 Did not backport filter functions such as ` _maybe_filter_configs_for_tma_restrictions` https://github.com/ROCm/pytorch/blob/release/2.9/torch/_inductor/runtime/triton_heuristics.py#L2614 --------- Co-authored-by: Jack Taylor <jack.taylor@amd.com> Co-authored-by: Jack Taylor <108682042+jataylo@users.noreply.github.com> Co-authored-by: Sampsa Riikonen <sriikone@amd.com> Co-authored-by: AmdSampsa <sampsa.riikonen@amd.com> (cherry picked from commit 7de1214)
|
Jenkins build for f7d9ee50fa5edff030e0abc3492f3dcd4a5383cc commit finished as FAILURE |
|
Jenkins build for 14768d0ee8771acdd0281489e85616b48220e117 commit finished as NOT_BUILT |
|
Jenkins build for 14768d0ee8771acdd0281489e85616b48220e117 commit finished as FAILURE |
Author
|
I ran the inductor/test_torchinductor.py and inductor/test_max_autotune.py test suites. There were no new regressions. |
naromero77amd
changed the title
naromero77amd
requested review from
jataylo,
jeffdaily,
jithunnair-amd and
pruthvistony
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is identical to this release/2.7 PR: #2807 but now for release/2.8. Because release/2.7 and release/2.8 are similar. Changes were first backported to release/2.7 and then cherry-picked into release/2.8.
-- Description from release/2.7 PR is included below
These are backports based on these upstream PRs. Cherrypicks were performed when they where possible.
pytorch#163908 (persistent reduction autotune)
pytorch#161280 (reduction) pytorch#162053 (foreach) pytorch#163197 (pointwise) pytorch#166470 (pointwise config for atomic add)
Also included are some additional customer-specific configs which were not upstreamed but are in this backport to 2.9
#2723
Did not backport filter functions such as
_maybe_filter_configs_for_tma_restrictionshttps://github.com/ROCm/pytorch/blob/release/2.9/torch/_inductor/runtime/triton_heuristics.py#L2614
(cherry picked from commit 7de1214)