Add mmq device table for RDNA3.5#25
Open
Annieren wants to merge 2 commits into
Open
Conversation
Collaborator
Code ReviewSummary of ChangesAdds RDNA3.5 (gfx115x) specific tuning to the CUDA/HIP MMQ (quantized matmul) path in
Checklist: summary present ✅, unit tests ⏭️ (perf-tuning constants only, no testable logic — validation is the benchmark + PPL data in the description). Potential Issues
Suggestions for Improvement
Overall: small, low-risk, well-validated tuning change — 27 models benchmarked on gfx1151 with bit-identical PPL and no decode regression. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add mmq device table for RDNA3.5.
Additional information
27 models including both dense and moe (gemma4_26b_a4b, qwen35_35b_a3b, qwen3_30b_a3b), from small (qwen25_05b, smollm2_17b, gemma2_2b) to large (qwen3_17b) models, all Q4_K_M were tests on gfx1151. Prefill at n=128 has the most performance boost, many models see +14% to +18% improvement. At longer sequences (512–4096), most models see a consistent +2% to +8% prefill improvement. It changes the mmq nwarps and mmq_y_max which do not impact mmvq's performance. Decode is essentially neutral, no regression.
PPL check has been performed, All 27 models are bit-identical.
Requirements