Honor timeout settings in subprocess run wrapper - #689
Open
ipanfilo wants to merge 2 commits into
Open
Conversation
Micky774
reviewed
Aug 3, 2026
Comment on lines
+37
to
+40
| explicit = int(os.environ.get("TE_DIST_LAUNCH_KILL_AFTER", "60")) | ||
| if run_timeout and run_timeout < 2*explicit: | ||
| return max(1, run_timeout // 2) | ||
| return max(1, explicit) |
Contributor
There was a problem hiding this comment.
What is run_timeout meant to be in contrast to explicit?
Collaborator
Author
There was a problem hiding this comment.
It is timeout passed to subprocess.run(). If explicit is too high, we split run_timeout to terminate and kill parts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix CI distributed tests RCCL EADDRINUSE failure after previous test timeout
Type of change
Changes
Torchrun timeout wrapper honors timeout setting from subprocess.run call
Checklist: