Fix vanilla channel interoperability with stock LDK - #149
Draft
bitwalt wants to merge 2 commits into
Draft
Conversation
bitwalt
force-pushed
the
upstream-stock-ldk-interop
branch
from
August 12, 2026 21:52
8a36aad to
b0af20e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 87.69% 87.74% +0.04%
==========================================
Files 16 16
Lines 8414 8459 +45
==========================================
+ Hits 7379 7422 +43
- Misses 1035 1037 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148.
This PR validates and integrates plain-channel interoperability with stock LDK. The corresponding Rust-Lightning fix is RGB-Tools/rust-lightning#36.
Changes
ldk-nodetest fixture undersrc/test/interoperability/ldk-nodeThe fixture is a separate Cargo crate so this repository's
[patch.crates-io]entries cannot replace its stock LDK dependencies. Its revision is locked for reproducible CI builds.Coverage
Four tests cover:
The successful private-channel payments also exercise invoice route hints without adding a separate route-hint assertion to this PR.
Merge order
RGB-Tools/rust-lightning#36 should merge first. Then this PR can restore the submodule URL to RGB-Tools and pin the merged commit before merging.
Validation
cargo fmt --package rgb-lightning-node -- --checkcargo fmt --manifest-path src/test/interoperability/ldk-node/Cargo.toml -- --checkcargo check --all-targetscargo test interoperability --no-rungit diff --checkCompatibility
The underlying Rust-Lightning fix changes wire and commitment transaction encoding. A release carrying it needs a coordinated upgrade for deployed channels. Persisted channel state itself is unchanged.