Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d094451e07
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d094451 to
0d1ed3f
Compare
0d1ed3f to
462d63c
Compare
RAPSNX
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9834874ebf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cdaa7843ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e55a5390b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1e55a53 to
29e02ed
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29e02edcc0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb7d155de0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bb7d155 to
59721b6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58894005b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "[ workspace special:aux silent ] sleep 2 && chromium --profile-directory=Default --app-id=dlgohinmglaoopaiplliaecdpmnepmga" | ||
| ] | ||
| ++ cfg.autostart; | ||
| ]; |
There was a problem hiding this comment.
When either Hyprland session starts, this fixed exec-once list no longer includes the former per-host commands: Firefly loses Mumble, Firefox, and Chromium startup, while Zion loses Firefox and its ddcutil input-selection command. I checked both host files and the repository-wide autostart configuration; xdg.autostart.enable was added, but no equivalent desktop entries were added for these commands, so they no longer run after login.
Useful? React with 👍 / 👎.
79d7af7 to
6aa47c6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6aa47c69dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| 2. **Revert Home Manager configuration** in `hosts/firefly/home.nix`: | ||
| - Set `roles.desktop.hyprland.configOnly = true;` under `roles.desktop.hyprland`. | ||
| - Remove or disable `xdg.portal` and `systemd.user.services.xdg-desktop-portal*` overrides so systemd user units fall back to host `/usr/lib/systemd/user/` definitions. |
There was a problem hiding this comment.
When a Firefly user follows this rollback, the named systemd.user.services.xdg-desktop-portal* overrides do not exist; the Nix portal units are actually supplied by systemd.user.packages in hosts/firefly/home.nix:123-127. Leaving that list in place both retains the Nix frontend/GTK units instead of the promised /usr/libexec stack and, after configOnly = true forces finalPortalPackage to null, can make sw-fly fail evaluation. Instruct the user to remove or guard the package-unit list as part of the rollback.
Useful? React with 👍 / 👎.
Fix session isolation and logout crash trigger (phase 1+2) Resolve service duplication and clean portal routing (phase 2) docs: track completion of phase 1 and 2 tasks Migrate portal ownership and declarative config to HM (phase 3) - Relocate generic-Linux portal packages to hyprland module - Migrate xdph.conf to wayland.windowManager.hyprland.xdph.settings with 60 FPS cap - Express PATH via systemd.user.sessionVariables - Narrow systemd imported environment variables - Remove unused hyprland-git flake input - docs: track completion of phase 3 tasks Update documentation and finalize screencopy performance decisions (phase 4) - Document explicit Nix vs Ubuntu ownership boundaries - Update portal discovery documentation for modern XDG data dir lookup - Detail package unit symlink cleanup in rollback procedures - Confirm screencopy performance decision to retain automatic fallback - docs: track completion of phase 4 tasks docs: track completion of phase 5 verification tasks - Flake evaluation: passed with zero warnings and zero assertion failures - Code style: statix, deadnix, and nixfmt clean - Build verification: home-manager generation and systemd user units verified
6aa47c6 to
ef2b0eb
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f33efd794b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Description = "get ondemand locally" | ||
| Output = "" | ||
| Tag = [] | ||
| command = "read -r OND_NAME && k get secrets -n ondemand \"$OND_NAME\"-credentials -oyaml | yq '.data.gardenKubeconfig' | base64 -d > ~/.garden/envs/ond.yaml" |
There was a problem hiding this comment.
When this snippet is run with a common 022 umask and ~/.garden/envs is traversable by other local users, the redirection creates ond.yaml as mode 0644, exposing the decoded Kubernetes credentials. Set a restrictive umask or write the file with mode 0600 before storing the secret.
Useful? React with 👍 / 👎.
f33efd7 to
7ba0cd5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e73b87415
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [ -f "$GCTL_CACHE" ] && source "$GCTL_CACHE" | ||
| eval $(gardenctl kubectl-env zsh) | ||
|
|
||
| source ~/.config/rapsn/additional.env |
There was a problem hiding this comment.
On a fresh Firefly installation, or whenever this unmanaged file has not been created, every interactive Zsh startup reports no such file or directory because neither Home Manager nor the bootstrap documentation provides it. Check that the file exists before sourcing it, or manage it declaratively.
Useful? React with 👍 / 👎.
c836424 to
9675ecf
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9675ecf768
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| end | ||
|
|
||
| local function one_shot(keys, dispatcher, description) | ||
| bind(keys, sequence(dispatcher, clear_notification(), submap("reset")), description) |
There was a problem hiding this comment.
When s or Shift+s is pressed before the Noctalia-mode banner expires, one_shot dispatches screenshot-region or screenshot-fullscreen before notification-clear-active; with screen freezing enabled, the capture can therefore include the banner. Fresh evidence after the annotated-capture fix is that only the A path now clears first, while both native screenshot bindings still use this reversed helper ordering.
Useful? React with 👍 / 👎.
9675ecf to
a7cb12b
Compare
|
|
||
| 2. Check atuin `key` match with the key in vault. | ||
|
|
||
| # System Architecture & Ownership Boundaries |
There was a problem hiding this comment.
The toggle firefox submap does not work
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b75dd5742a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| criteria = "eDP-1"; | ||
| mode = "1920x1200@60.00Hz"; | ||
| scale = 1.0; |
There was a problem hiding this comment.
When the RallyBar and eDP-1 activate this new profile, the laptop display still inherits the global position = "6000,0" setting at the top of this file because the profile overrides only its mode and scale. With the 1920-wide RallyBar using its normal/default placement, this leaves a multi-thousand-pixel gap between outputs rather than an adjacent meeting-room layout; set explicit positions for both outputs in this profile.
Useful? React with 👍 / 👎.
b75dd57 to
0220ff1
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6143fe8a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| # Portable temporary VM | ||
| "rap@devbox" = lib.homeManagerConfiguration { | ||
| modules = homeModules ++ [ ./hosts/devbox/home.nix ]; |
There was a problem hiding this comment.
Evaluating the new rap@devbox output fails before producing an activation package: homeModules imports modules/home/common/roles.nix and modules/home/cli/zsh/default.nix, both of which require a mylib module argument, but this configuration's extraSpecialArgs supplies only inputs. Pass mylib here as the other Home Manager outputs do.
AGENTS.md reference: AGENTS.md:L26-L26
Useful? React with 👍 / 👎.
d6143fe to
8ee343a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ee343a55d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assertion = builtins.all (v: builtins.elem v variables) required; | ||
| message = "Hyprland systemd variables are missing required session environment variables."; |
There was a problem hiding this comment.
Fresh evidence after the earlier mylib finding is that rap@devbox now imports all homeModules without enabling roles.desktop.hyprland, yet this assertion is applied unconditionally. Home Manager's disabled-role default variable list does not include XDG_SESSION_TYPE, so evaluating the new rap@devbox output fails with this assertion instead of producing an activation package; wrap these assertions in lib.mkIf config.roles.desktop.hyprland.enable.
AGENTS.md reference: AGENTS.md:L25-L26
Useful? React with 👍 / 👎.
| hl.exec_cmd(${toLua "[ workspace special:scratchy silent ] alacritty -t scratchy"}) | ||
| ${lib.concatMapStringsSep "\n " (cmd: "hl.exec_cmd(${toLua cmd})") cfg.autostart} |
There was a problem hiding this comment.
Although the per-host autostarts from the earlier review were restored, this shared start hook still omits the former Chromium Todoist PWA command (--app-id=dlgohinmglaoopaiplliaecdpmnepmga) that was in exec-once. A repository-wide search finds no replacement, so Todoist no longer starts in the auxiliary workspace on either desktop login; add the command to this hook or to the applicable host autostarts.
Useful? React with 👍 / 👎.
8ee343a to
a1b4063
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1b406384d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| green = "#a6e3a1"; | ||
| }; | ||
|
|
||
| format = lib.concatStrings [ |
There was a problem hiding this comment.
After the already-reported Hyprland assertion is guarded, evaluating rap@devbox still fails because homeModules automatically imports modules/home/cli/starship/default.nix, which defines programs.starship.settings.format, directory.truncation_length, and git_branch differently at the same priority. Nix therefore reports conflicting definitions instead of producing an activation package; reuse the shared Starship configuration or explicitly override it with lib.mkForce.
AGENTS.md reference: AGENTS.md:L11-L11
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
A full activation build was not completed locally because the daemon cannot trust the Noctalia cache and would fetch about 2.5 GiB.