Post Resolution search visualizations#658
Conversation
Updated resolution search schema, agent prompt, and carousel component to support dynamic, contextual labels based on AI analysis and user-drawn features. Co-authored-by: ngoiyaeric <115367894+ngoiyaeric@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 50 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
You see the labeling and box drawn on the right side, its random. It should be contextual
|
- Added critical guidelines to prevent generic or random labels. - Instructed AI to prioritize user-drawn features and avoid hallucinated GeoJSON. - Enhanced contextual labeling requirements to be highly specific. Co-authored-by: ngoiyaeric <115367894+ngoiyaeric@users.noreply.github.com>
@coderabbitai why doesn't it know what its pointing at. The blue box and red dot are out of context
|
- Updated `resolutionSearchSchema` to require high-confidence and relevant GeoJSON features. - Enhanced `resolutionSearch` agent system prompt with critical guidelines to avoid generic/random labels and hallucinations. - Added strict contextual alignment instructions for user-drawn features. Co-authored-by: ngoiyaeric <115367894+ngoiyaeric@users.noreply.github.com>
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Look at the resolution search agent system prompt and how marker/pointer coordinates are passed
cat $(fd -e tsx -e ts "resolution-search" | head -5)
echo "---actions.tsx---"
cat $(fd -e tsx "actions" --max-depth 3 | grep "app/actions" | head -1)
echo "---resolution-carousel.tsx---"
cat $(fd -e tsx "resolution-carousel" | head -1)Length of output: 44767 🏁 Script executed: rg -n "Geographic Coordinates" lib/agents/resolution-search.tsxLength of output: 154 🏁 Script executed: rg -n "resolution_search\|cursorLat\|cursorLng\|append.*action\|resolution_search" components/ --type tsx -A5 -B2
fd -e tsx "header-search-button" | xargs cat
fd -e tsx "search-button" | xargs cat 2>/dev/null | head -200Length of output: 14899 🏁 Script executed: fd -e tsx -e ts "map-data-context" | xargs catLength of output: 1821 🏁 Script executed: # Find map click event handlers
rg -n "on.*[Cc]lick\|\.on\('click'\|\.on\(\"click\"" --type-add 'tsx:*.tsx' --type tsx -A4 -B2
rg -n "on.*[Cc]lick\|\.on\('click'\|\.on\(\"click\"" --type-add 'ts:*.ts' --type ts -A4 -B2 | head -100Length of output: 473 🏁 Script executed: # Find map click handlers using glob patterns
rg -n "onClick\|\.on\('click'\|\.on\(\"click\"\|map\.on\|'click'" components/map/ -A4 -B2 | head -120
# Also list all files in the map directory
fd . components/map/ -e tsx -e tsLength of output: 627 🏁 Script executed: # Read the most likely files to contain click handlers
echo "=== mapbox-map.tsx ==="
cat components/map/mapbox-map.tsx
echo "=== google-map.tsx ==="
cat components/map/google-map.tsx
echo "=== map-3d.tsx (first 100 lines) ==="
head -100 components/map/map-3d.tsxLength of output: 26788
Complete Fix: Wire cursor location from map click → agent
🧠 Learnings usedThe requested changes have been implemented and a pull request has been created: View PR |
|
Closing this pull request as part of a bulk cleanup of pending PRs. |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
![charliecreates[bot]](https://avatars.githubusercontent.com/in/1140780?s=60&v=4){kind=small}
There was a problem hiding this comment.
Checked the diff and current checks (GitGuardian/Vercel green; license/cla is still pending).
Blocking feedback
- Contextual labels are only wired through the rehydration path, so fresh
resolution_searchresponses still show fallback labels until a reload —app/actions.tsx#L833-L839
Non-blocking feedback (1)
- Unrelated local runtime output was committed in
server.log—server.log#L5-L69
This file now includes local dev requests/errors (including/test-carouselfailures), which makes the PR noisy and increases avoidable merge churn. Consider dropping this file from the PR unless log snapshots are intentionally versioned for this feature.
If you'd like me to push fixes, reply with the item number(s) you want addressed (for example: please fix 1).
| mapboxImage={mapboxImage} | ||
| googleImage={googleImage} | ||
| initialImage={image} | ||
| mapboxImageLabel={mapboxImageLabel} |
There was a problem hiding this comment.
These new label props are only applied in getUIStateFromAIState (rehydration). The first streamed resolution_search response in submit() still renders ResolutionCarousel without mapboxImageLabel / googleImageLabel / analysisFocus (around lines 227-231), so users keep seeing fallback labels (MAPBOX, GOOGLE SATELLITE, MAP CAPTURE) until they reload the chat.
Suggested fix: once analysisResult resolves, update the streamed carousel with these three fields (or make those labels streamable values so the initial response updates in-place).
… resolution search accuracy. Here is a summary of the changes: - Added `cursorLocation` tracking to `MapDataContext`, `MapboxMap`, and `Map3D`. - Forwarded the `cursorLocation` through the `HeaderSearchButton` and the search execution flow. - Updated the `resolutionSearch` agent to prioritize user clicks and specific points for geocoding and analysis. - Refined the `resolutionSearchSchema` and system prompt to ensure high-confidence, contextual overlays and labels. - Suppressed generic or "random" GeoJSON features in favor of highly relevant landmarks. Co-authored-by: ngoiyaeric <115367894+ngoiyaeric@users.noreply.github.com>
2 participants
This PR enhances the resolution search visualizations by making them more contextual to user needs and queries.
Key changes:
mapboxImageLabel,googleImageLabel, andanalysisFocusfields to theresolutionSearchSchemainlib/schema/resolution-search.ts.resolutionSearchagent's system prompt inlib/agents/resolution-search.tsxto generate these labels and explicitly focus on user-drawn features.ResolutionCarouselincomponents/resolution-carousel.tsxto accept and display these dynamic labels.app/actions.tsxto pass the analysis results from the agent to the UI component.PR created automatically by Jules for task 14462340195639869331 started by @ngoiyaeric