GeoJSON Upload and Tool Ingestion Pipeline

[ngoiyaeric]

User description

This change enables users to upload GeoJSON files (.geojson, application/geo+json) directly through the chat interface. Uploaded data is automatically rendered on the map (both Mapbox and Google Maps) and the viewport is adjusted to frame the data's extent using Turf.js.

The implementation includes:

• A new uploadedGeoJson field in MapDataContext.
• Server-side parsing and validation of GeoJSON in the submit action.
• A headless MapDataUpdater component that manages state synchronization and "fly to" behavior.
• Database persistence for GeoJSON layers, ensuring they reappear when a chat is reloaded.
• Extension of the geospatialTool to allow AI agents to return GeoJSON that is processed through the same pipeline.
• Improved testability with new data-testid attributes.

---

PR created automatically by Jules for task 11124993269366174034 started by @ngoiyaeric

---

PR Type

Enhancement

---

Description

• Enable GeoJSON file uploads (.geojson, application/geo+json) through chat interface

• Automatically render uploaded GeoJSON on maps with viewport framing using Turf.js

• Persist GeoJSON layers in database for chat session reload capability

• Allow AI agents to return GeoJSON through geospatial tool pipeline

• Add MapDataUpdater component for state synchronization and map navigation

---

Diagram Walkthrough

flowchart LR
  A["User uploads GeoJSON file"] --> B["Parse and validate GeoJSON"]
  B --> C["MapDataUpdater component"]
  C --> D["Update MapData context"]
  D --> E["Render on Mapbox/Google Maps"]
  E --> F["Fit map bounds with Turf.js"]
  F --> G["Persist to database"]
  H["AI tool returns GeoJSON"] --> I["MapQueryHandler processes result"]
  I --> C

Loading

File Walkthrough

	Relevant files
Enhancement	10 files chat.ts Add uploadedGeoJson field to context update                            +1/-1      actions.tsx Implement GeoJSON file parsing and upload pipeline              +60/-1    chat-panel.tsx Add GeoJSON file type to upload input accept                          +2/-1      chat.tsx Sync uploadedGeoJson to server via updateDrawingContext    +6/-5      map-data-context.tsx Add uploadedGeoJson array to MapData interface                      +11/-1    map-data-updater.tsx Create headless component for GeoJSON context sync              +63/-0    map-query-handler.tsx Integrate MapDataUpdater for tool GeoJSON results                +13/-1    mapbox-map.tsx Render uploaded GeoJSON layers on Mapbox                                  +4/-0      google-map.tsx Render uploaded GeoJSON layers on Google Maps                        +3/-0      geospatial.tsx Extract and pass GeoJSON from geospatial tool results        +28/-3
Tests	2 files message.tsx Add data-testid attribute to bot message                                  +1/-1      user-message.tsx Add data-testid attribute to user message                                +1/-1

---

Summary by CodeRabbit

• New Features

  • Upload or paste GeoJSON (files or inline) and have it added to chat as a data item and rendered as map layers.
  • Multiple uploaded GeoJSON items supported with visibility toggles; map auto-zooms to uploaded data.
  • GeoJSON returned by geospatial tools is automatically added to the map.

• Bug Fixes

  • Improved detection and error handling for invalid GeoJSON inputs.

• Tests

  • Added test IDs to file upload and message elements for easier automated testing.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
qcx	Ready	Preview, Comment	Feb 3, 2026 11:26am

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ ngoiyaeric
❌ google-labs-jules[bot]
❌ CJWTRUST
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

Walkthrough

Detects inline or uploaded GeoJSON on submit, emits a geojson_upload AI message, streams a headless MapDataUpdater UI item to append entries to mapData.uploadedGeoJson, renders those entries as GeoJSON layers in Mapbox/Google maps, and persists uploadedGeoJson in the drawing-context message (deduplicated/upserted).

Changes

Cohort / File(s)	Summary
File submit & AI state app/actions.tsx, components/chat-panel.tsx	Detect/parses inline JSON and .geojson/application/geo+json uploads; emit geojson_upload AI messages and stream a MapDataUpdater UI message. Added data-testid="file-upload-input" on file input.
Chat sync / drawing context components/chat.tsx, lib/actions/chat.ts	Include uploadedGeoJson in drawing-context payload; add snapshot/dedup guards to avoid redundant updates. updateDrawingContext signature now accepts optional uploadedGeoJson and will update existing data-type messages instead of always creating new ones.
Map data model & updater components/map/map-data-context.tsx, components/map/map-data-updater.tsx	Add uploadedGeoJson array to MapData. New MapDataUpdater normalizes Feature/FeatureCollection, appends unique uploaded entries ({id, filename, data, visible}), and fits map bounds once using turf.bbox.
Map rendering layers components/map/google-map.tsx, components/map/mapbox-map.tsx	Render additional GeoJSON layers for each visible item in mapData.uploadedGeoJson (GoogleGeoJsonLayer / GeoJsonLayer).
Tooling & parsing lib/agents/tools/geospatial.tsx, components/map/map-query-handler.tsx	Surface geoJson from MCP/tool responses (added optional geoJson to McpResponse); render MapDataUpdater for tool-produced GeoJSON results.
DB schema & persistence drizzle/migrations/..., lib/db/schema.ts, lib/actions/chat-db.ts	Add calendar_notes table and add attachments, tool_name, tool_call_id, type to messages (migration + schema). Message insert changed to upsert (on conflict do update) to deduplicate by id.
Types & test attributes lib/types/index.ts, components/message.tsx, components/user-message.tsx	Add geojson_upload to AIMessage.type; add data-testid attributes to message components for testing.
Deps / snapshots package.json, drizzle/migrations/meta/*	Bump drizzle-orm dependency and add/update migration snapshot and journal metadata files.

Sequence Diagram

sequenceDiagram
    actor User
    participant ChatPanel as Chat Panel
    participant Actions as app/actions
    participant AIState as AI State
    participant MapUpdater as MapDataUpdater
    participant MapContext as MapData Context
    participant MapRenderer as Map Components

    User->>ChatPanel: paste or upload GeoJSON
    ChatPanel->>Actions: submit(text/file)
    Actions->>Actions: detect & parse GeoJSON
    Actions->>AIState: push 'geojson_upload' message (id, filename, data)
    Actions->>MapUpdater: stream MapDataUpdater component
    MapUpdater->>MapContext: add uploadedGeoJson entry {id, filename, data, visible:true}
    MapUpdater->>MapUpdater: compute bbox (turf.bbox)
    MapUpdater->>MapRenderer: call fitBounds(bbox)
    MapRenderer->>User: render GeoJsonLayer(s)

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• feat: Add Resolution Search agent for map analysis #316: Overlaps on chat submit and file-upload handling and AI→map integration; likely related to app/actions and MapDataUpdater streaming.
• feat: Enable file attachments in chat #303: Shares file-attachment and chat-panel input handling changes relevant to GeoJSON upload UI and parsing.
• Synchronize Map State Between Mapbox and Google Maps #409: Modifies chat→map sync flow and the updateDrawingContext payload; directly related to uploadedGeoJson propagation and dedup logic.

Suggested labels

Backend

Poem

🐇 I found a GeoJSON neat and round,

I hopped its features into town,
Layers bloomed where bounds took flight,
The map stretched wide — what a sight,
Cheers from a rabbit, lightly bound!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'GeoJSON Upload and Tool Ingestion Pipeline' accurately reflects the main objective of the PR, which enables end-to-end GeoJSON ingestion through the chat interface and AI tool results.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/geojson-upload-pipeline-11124993269366174034

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

• ✨ 136.113.208.247/32 (new)
• 34.170.211.100/32
• 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[qodo-code-review]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
⚪	Denial of service Description: Unbounded GeoJSON ingestion (Buffer -> JSON.parse) on user-uploaded files without enforcing file size/feature-count limits can be exploited to cause server memory/CPU exhaustion (e.g., uploading a very large .geojson or deeply nested JSON). actions.tsx [319-350] Referred Code } else if (file.type === 'text/plain' || file.name.endsWith('.geojson') || file.type === 'application/geo+json') { const textContent = Buffer.from(buffer).toString('utf-8') const isGeoJson = file.name.endsWith('.geojson') || file.type === 'application/geo+json' if (isGeoJson) { try { const geoJson = JSON.parse(textContent) if (geoJson.type === 'FeatureCollection' || geoJson.type === 'Feature') { const geoJsonId = nanoid() // Add a special message to track the GeoJSON upload aiState.update({ ...aiState.get(), messages: [ ...aiState.get().messages, { id: geoJsonId, role: 'assistant', content: JSON.stringify({ data: geoJson, filename: file.name }), type: 'geojson_upload' } ] ... (clipped 11 lines)
	Client-side DoS Description: Rendering and processing untrusted GeoJSON on the client (notably turf.bbox(featureCollection) and map.fitBounds) without complexity limits can freeze the UI or crash the tab when given extremely large/complex GeoJSON from uploads or tool output. map-data-updater.tsx [19-60] Referred Code useEffect(() => { if (!data) return; // Ensure it's a FeatureCollection for consistency const featureCollection: FeatureCollection = data.type === 'FeatureCollection' ? data : { type: 'FeatureCollection', features: [data] }; // Update MapData context setMapData(prev => { // Avoid duplicate entries const alreadyExists = prev.uploadedGeoJson?.some(item => item.id === id); if (alreadyExists) return prev; return { ...prev, uploadedGeoJson: [ ...(prev.uploadedGeoJson || []), { id, filename, ... (clipped 21 lines)
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
🔴	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Missing audit logging: The GeoJSON upload/ingestion path adds and persists user-supplied GeoJSON but does not emit a structured audit log including user ID, action description, and outcome to reconstruct who uploaded what and whether it succeeded. Referred Code } else if (file.type === 'text/plain' || file.name.endsWith('.geojson') || file.type === 'application/geo+json') { const textContent = Buffer.from(buffer).toString('utf-8') const isGeoJson = file.name.endsWith('.geojson') || file.type === 'application/geo+json' if (isGeoJson) { try { const geoJson = JSON.parse(textContent) if (geoJson.type === 'FeatureCollection' || geoJson.type === 'Feature') { const geoJsonId = nanoid() // Add a special message to track the GeoJSON upload aiState.update({ ...aiState.get(), messages: [ ...aiState.get().messages, { id: geoJsonId, role: 'assistant', content: JSON.stringify({ data: geoJson, filename: file.name }), type: 'geojson_upload' } ] ... (clipped 11 lines) Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Silent parse failure: GeoJSON parsing failures are only logged via console.error and the request continues without surfacing an actionable error to the user or recording a failure outcome, making troubleshooting and UX degraded. Referred Code if (isGeoJson) { try { const geoJson = JSON.parse(textContent) if (geoJson.type === 'FeatureCollection' || geoJson.type === 'Feature') { const geoJsonId = nanoid() // Add a special message to track the GeoJSON upload aiState.update({ ...aiState.get(), messages: [ ...aiState.get().messages, { id: geoJsonId, role: 'assistant', content: JSON.stringify({ data: geoJson, filename: file.name }), type: 'geojson_upload' } ] }) // Immediately append the updater to the UI stream uiStream.append( ... (clipped 6 lines) Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Logs raw tool data: The tool logs potentially sensitive unredacted content and echoes params via JSON.stringify(params) which may include user-provided locations/addresses or other sensitive details in unstructured console logs. Referred Code try { content = JSON.parse(content); } catch { console.warn('[GeospatialTool] Content is not JSON, using as string:', content); } // Process results if (typeof content === 'object' && content !== null) { const parsedData = content as any; if (parsedData.results?.length > 0) { const firstResult = parsedData.results[0]; mcpData = { location: { latitude: firstResult.coordinates?.latitude, longitude: firstResult.coordinates?.longitude, place_name: firstResult.name || firstResult.place_name, address: firstResult.full_address || firstResult.address }, mapUrl: parsedData.mapUrl, geoJson: parsedData.geoJson || parsedData.geojson || firstResult.geoJson || firstResult.geojson }; } else if (parsedData.location) { mcpData = { location: { ... (clipped 20 lines) Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Weak GeoJSON validation: Uploaded GeoJSON is accepted after only a shallow type check (Feature/FeatureCollection) without schema validation, size/feature-count limits, or sanitization, increasing risk of malformed/hostile input affecting storage and rendering. Referred Code } else if (file.type === 'text/plain' || file.name.endsWith('.geojson') || file.type === 'application/geo+json') { const textContent = Buffer.from(buffer).toString('utf-8') const isGeoJson = file.name.endsWith('.geojson') || file.type === 'application/geo+json' if (isGeoJson) { try { const geoJson = JSON.parse(textContent) if (geoJson.type === 'FeatureCollection' || geoJson.type === 'Feature') { const geoJsonId = nanoid() // Add a special message to track the GeoJSON upload aiState.update({ ...aiState.get(), messages: [ ...aiState.get().messages, { id: geoJsonId, role: 'assistant', content: JSON.stringify({ data: geoJson, filename: file.name }), type: 'geojson_upload' } ] ... (clipped 7 lines) Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Overuse of any: New GeoJSON pipeline types use broad any (e.g., data: any, uploadedGeoJson entries with data: any) which reduces self-documentation and makes intent and constraints unclear. Referred Code interface MapDataUpdaterProps { id: string; data: any; // FeatureCollection or Feature filename: string; } Learn more about managing compliance generic rules or creating your own custom rules
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-code-review]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	✅ Prevent repeated map view updates Suggestion Impact: The commit adds a hasZoomedRef guard so map.fitBounds() runs only once, preventing repeated map view updates, though it uses a ref-based approach instead of checking existing GeoJSON in context. code diff: -import { useEffect } from 'react'; +import { useEffect, useRef } from 'react'; import { useMapData } from './map-data-context'; import { useMap } from './map-context'; import type { FeatureCollection } from 'geojson'; @@ -15,6 +15,7 @@ export function MapDataUpdater({ id, data, filename }: MapDataUpdaterProps) { const { setMapData } = useMapData(); const { map } = useMap(); + const hasZoomedRef = useRef(false); useEffect(() => { if (!data) return; @@ -45,7 +46,8 @@ }); // Fly to the extent of the GeoJSON - if (map && featureCollection.features.length > 0) { + if (map && featureCollection.features.length > 0 && !hasZoomedRef.current) { + hasZoomedRef.current = true; try { const bbox = turf.bbox(featureCollection); map.fitBounds(bbox as [number, number, number, number], { In MapDataUpdater, prevent the useEffect from repeatedly calling map.fitBounds() by checking if the GeoJSON data has already been processed and exiting early. components/map/map-data-updater.tsx [15-63] export function MapDataUpdater({ id, data, filename }: MapDataUpdaterProps) { - const { setMapData } = useMapData(); + const { mapData, setMapData } = useMapData(); const { map } = useMap(); useEffect(() => { if (!data) return; + + // Prevent re-processing if the data is already in the context. + const alreadyExists = mapData.uploadedGeoJson?.some(item => item.id === id); + if (alreadyExists) { + return; + } // Ensure it's a FeatureCollection for consistency const featureCollection: FeatureCollection = data.type === 'FeatureCollection' ? data : { type: 'FeatureCollection', features: [data] }; // Update MapData context - setMapData(prev => { - // Avoid duplicate entries - const alreadyExists = prev.uploadedGeoJson?.some(item => item.id === id); - if (alreadyExists) return prev; + setMapData(prev => ({ + ...prev, + uploadedGeoJson: [ + ...(prev.uploadedGeoJson || []), + { + id, + filename, + data: featureCollection, + visible: true + } + ] + })); - return { - ...prev, - uploadedGeoJson: [ - ...(prev.uploadedGeoJson || []), - { - id, - filename, - data: featureCollection, - visible: true - } - ] - }; - }); - - // Fly to the extent of the GeoJSON + // Fly to the extent of the GeoJSON only once if (map && featureCollection.features.length > 0) { try { const bbox = turf.bbox(featureCollection); map.fitBounds(bbox as [number, number, number, number], { padding: 50, maxZoom: 15, duration: 2000 }); } catch (e) { console.error('Failed to fit bounds for GeoJSON:', e); } } - }, [id, data, filename, setMapData, map]); + }, [id, data, filename, setMapData, map, mapData.uploadedGeoJson]); return null; // Headless component } [Suggestion processed] Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies that map.fitBounds() is called on every render, causing a poor user experience, and provides a correct fix to run the effect only once per GeoJSON upload.	Medium
	Safely access nested response properties In lib/agents/tools/geospatial.tsx, use optional chaining (?.) instead of logical OR (||) to safely access nested geoJson properties from the API response, preventing potential runtime errors. lib/agents/tools/geospatial.tsx [393] -geoJson: parsedData.geoJson || parsedData.geojson || firstResult.geoJson || firstResult.geojson +geoJson: parsedData.geoJson ?? parsedData.geojson ?? firstResult?.geoJson ?? firstResult?.geojson Apply / Chat Suggestion importance[1-10]: 6 __ Why: The suggestion correctly proposes using optional chaining (?.) for safer property access, which improves code robustness against potentially missing nested properties in the API response.	Low
General	Provide feedback for invalid uploads In app/actions.tsx, provide user feedback for invalid GeoJSON uploads by appending a BotMessage to the uiStream within the catch block and for files that are not valid GeoJSON features. app/actions.tsx [323-350] if (isGeoJson) { try { const geoJson = JSON.parse(textContent) if (geoJson.type === 'FeatureCollection' || geoJson.type === 'Feature') { const geoJsonId = nanoid() // Add a special message to track the GeoJSON upload aiState.update({ ...aiState.get(), messages: [ ...aiState.get().messages, { id: geoJsonId, role: 'assistant', content: JSON.stringify({ data: geoJson, filename: file.name }), type: 'geojson_upload' } ] }) // Immediately append the updater to the UI stream uiStream.append( <MapDataUpdater id={geoJsonId} data={geoJson} filename={file.name} /> ) + } else { + // Handle cases where JSON is valid but not a GeoJSON Feature or FeatureCollection + uiStream.append(<BotMessage content="The uploaded file is not a valid GeoJSON Feature or FeatureCollection." />) } } catch (e) { console.error('Failed to parse GeoJSON:', e) + uiStream.append(<BotMessage content="The uploaded file could not be parsed as valid GeoJSON." />) } } [To ensure code accuracy, apply this suggestion manually] Suggestion importance[1-10]: 8 __ Why: The suggestion improves user experience by providing feedback on invalid file uploads, which is a crucial part of error handling for this new feature.	Medium
	Use case-insensitive extension check In app/actions.tsx, make the GeoJSON file detection case-insensitive by converting file.name to lowercase before checking if it ends with .geojson. app/actions.tsx [319-321] -} else if (file.type === 'text/plain' || file.name.endsWith('.geojson') || file.type === 'application/geo+json') { +} else if ( + file.type === 'text/plain' || + file.name.toLowerCase().endsWith('.geojson') || + file.type === 'application/geo+json' +) { const textContent = Buffer.from(buffer).toString('utf-8') - const isGeoJson = file.name.endsWith('.geojson') || file.type === 'application/geo+json' + const isGeoJson = + file.name.toLowerCase().endsWith('.geojson') || + file.type === 'application/geo+json' Apply / Chat Suggestion importance[1-10]: 5 __ Why: The suggestion makes the file type detection more robust by handling case-insensitive file extensions, which is a good practice for file handling.	Low
	Filter items before rendering In GoogleMapComponent, refactor the rendering of uploadedGeoJson to use .filter(item => item.visible) before .map() to avoid returning boolean values in the render array. components/map/google-map.tsx [84-86] -{mapData.uploadedGeoJson?.map(item => ( - item.visible && <GoogleGeoJsonLayer key={item.id} data={item.data} /> -))} +{mapData.uploadedGeoJson + ?.filter(item => item.visible) + .map(item => ( + <GoogleGeoJsonLayer key={item.id} data={item.data} /> + ))} Apply / Chat Suggestion importance[1-10]: 4 __ Why: The suggestion improves code style and robustness by using .filter() before .map(), which is a clearer and safer pattern for conditional rendering in React than using &&.	Low
Update

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In `@app/actions.tsx`:
- Around line 697-703: The map callback over aiState.messages (inside the
function handling message rendering where actualLastDataIndex is used) does not
return on every path — update the switch inside that callback (the switch
handling message.type/name/etc.) to include an explicit return in the
default/fallthrough case (e.g., return null or the intended fallback JSX/value)
so the callback always returns a value and you no longer rely on later filtering
to remove undefined results; ensure you reference the same variables (message,
index, role, content, id, type, name) and keep existing early returns for role
=== 'data' and other explicit cases.

In `@components/map/mapbox-map.tsx`:
- Line 471: The map initialization effect is re-running and tearing down the map
because it lists mapData.cameraState and position?.latitude/position?.longitude
as dependencies; since the effect's cleanup sets map.current = null this causes
full reinitialization on every camera or position update. Fix by removing
mapData.cameraState and position?.latitude and position?.longitude from the
dependency array of the effect (keep only setup callbacks like setMap,
setIsMapLoaded, captureMapCenter, handleUserInteraction, stopRotation), so the
map is initialized once and position/camera updates are handled by their
dedicated effects.

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9450b15 and 85a85c5.

📒 Files selected for processing (4)

• app/actions.tsx
• components/chat-panel.tsx
• components/chat.tsx
• components/map/mapbox-map.tsx

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2026-01-13T13:26:30.086Z

Learnt from: ngoiyaeric
Repo: QueueLab/QCX PR: 0
File: :0-0
Timestamp: 2026-01-13T13:26:30.086Z
Learning: Workers that rely on ai.generateObject (geojsonParser, map-command-generator, feedback-analyzer) must not use the X.AI 'grok-4-fast-non-reasoning' model because X.AI’s chat/completions rejects JSON Schema structured-output arguments; prefer OpenAI gpt-4o for structured outputs.

Applied to files:

• app/actions.tsx

🧬 Code graph analysis (1)

components/map/mapbox-map.tsx (1)

components/map/geojson-layer.tsx (4)

• GeoJsonLayer (13-100)
• map (24-80)
• map (89-96)
• GeoJsonLayerProps (8-11)

🪛 Biome (2.3.13)

app/actions.tsx

[error] 698-698: This callback passed to map() iterable method should always return a value.

Add missing return statements so that this callback returns a value on all execution paths.

(lint/suspicious/useIterableCallbackReturn)

🔇 Additional comments (4)

components/chat-panel.tsx (1)

217-218: LGTM! GeoJSON file type support added correctly.

The accept attribute properly includes both the file extension (.geojson) and the MIME type (application/geo+json) for broader compatibility. The data-testid attribute improves testability.

components/chat.tsx (1)

79-85: Good fix for the infinite refresh loop.

The lastRefreshedMessageIdRef guard effectively prevents repeated router.refresh() calls for the same response message. This addresses the refresh loop issue mentioned in the PR comments.

app/actions.tsx (1)

863-882: Good error handling for data message parsing.

The try-catch wrapper around JSON parsing and the validation of uploadedGeoJson array structure is a good defensive pattern. This correctly handles malformed data messages without crashing the UI state reconstruction.

components/map/mapbox-map.tsx (1)

597-599: No issues with GeoJsonLayer placement.

The GeoJsonLayer components are properly positioned as siblings in the JSX return statement. Since GeoJsonLayer returns null and accesses the Mapbox map instance exclusively via the useMap() context hook, the DOM relationship is irrelevant. The context is available because Mapbox is rendered within MapContextProvider (as shown in app/layout.tsx). The component's useEffect safely handles the async nature of map initialization with a if (!map || !data) return guard. This is a correct pattern for side-effect components that manipulate the map via context without rendering DOM elements.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Map callback does not explicitly return on all paths.

The static analysis tool correctly identifies that the callback passed to map() at line 698 doesn't always return a value. While the early returns at lines 701-703 and 711 handle some cases, the switch statement inside may fall through without returning.

The current code relies on the filter at line 890 to remove undefined values, but explicit returns improve clarity and prevent subtle bugs.

🛡️ Proposed fix - add explicit return at switch default

         default:
           return {
             id,
             component: null
           }
       }
+      return null // Explicit return for unhandled cases within switch
     })
     .filter(message => message !== null) as UIState

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	return aiState.messages
	.map((message, index) => {
	const { role, content, id, type, name } = message
	if (role === 'data' && index !== actualLastDataIndex) {
	return null
	}
	return aiState.messages
	.map((message, index) => {
	const { role, content, id, type, name } = message
	if (role === 'data' && index !== actualLastDataIndex) {
	return null
	}
	switch (type) {
	// ... switch cases ...
	default:
	return {
	id,
	component: null
	}
	}
	return null // Explicit return for unhandled cases within switch
	})
	.filter(message => message !== null) as UIState

🧰 Tools

🪛 Biome (2.3.13)

[error] 698-698: This callback passed to map() iterable method should always return a value.

Add missing return statements so that this callback returns a value on all execution paths.

(lint/suspicious/useIterableCallbackReturn)

🤖 Prompt for AI Agents

In `@app/actions.tsx` around lines 697 - 703, The map callback over
aiState.messages (inside the function handling message rendering where
actualLastDataIndex is used) does not return on every path — update the switch
inside that callback (the switch handling message.type/name/etc.) to include an
explicit return in the default/fallthrough case (e.g., return null or the
intended fallback JSX/value) so the callback always returns a value and you no
longer rely on later filtering to remove undefined results; ensure you reference
the same variables (message, index, role, content, id, type, name) and keep
existing early returns for role === 'data' and other explicit cases.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Read the effect at line 471 with context
sed -n '460,485p' components/map/mapbox-map.tsx | cat -n

Repository: QueueLab/QCX

Length of output: 1181

---

🏁 Script executed:

#!/bin/bash
# Find where mapData.cameraState is defined/updated
rg -n "cameraState" components/map/mapbox-map.tsx -B2 -A2

Repository: QueueLab/QCX

Length of output: 708

---

🏁 Script executed:

#!/bin/bash
# Search for setCameraState to understand update patterns
rg -n "setCameraState" components/map/ -A1

Repository: QueueLab/QCX

Length of output: 38

---

🏁 Script executed:

#!/bin/bash
# Look for the full effect hook starting from line 450
sed -n '440,480p' components/map/mapbox-map.tsx | cat -n

Repository: QueueLab/QCX

Length of output: 1780

---

🏁 Script executed:

#!/bin/bash
# Find the complete effect hook starting from an earlier line
sed -n '330,380p' components/map/mapbox-map.tsx | cat -n

Repository: QueueLab/QCX

Length of output: 2010

---

🏁 Script executed:

#!/bin/bash
# Search for initializedRef to see the guard logic
rg -n "initializedRef" components/map/mapbox-map.tsx -B2 -A2

Repository: QueueLab/QCX

Length of output: 619

---

🏁 Script executed:

#!/bin/bash
# Check if position object is frequently updated in state
rg -n "setPosition|position:" components/map/mapbox-map.tsx -C1 | head -40

Repository: QueueLab/QCX

Length of output: 198

---

🏁 Script executed:

#!/bin/bash
# Find where position state is updated
rg -n "const \[position" components/map/mapbox-map.tsx -A5

Repository: QueueLab/QCX

Length of output: 38

---

🏁 Script executed:

#!/bin/bash
# Look for geolocation updates that would change position
rg -n "watchPosition|success.*position" components/map/mapbox-map.tsx -B2 -A5

Repository: QueueLab/QCX

Length of output: 324

---

🏁 Script executed:

#!/bin/bash
# Get component function signature to see if position is a prop
sed -n '1,50p' components/map/mapbox-map.tsx | cat -n

Repository: QueueLab/QCX

Length of output: 2981

---

🏁 Script executed:

#!/bin/bash
# Search for where position prop/state is passed or defined
rg -n "position" components/map/mapbox-map.tsx | head -20

Repository: QueueLab/QCX

Length of output: 1147

---

🏁 Script executed:

#!/bin/bash
# Check the component's type definition or interface
rg -n "interface.*Props|type.*Props" components/map/mapbox-map.tsx -A20

Repository: QueueLab/QCX

Length of output: 38

---

Remove position and cameraState from map initialization effect dependencies—they cause the map to be torn down and rebuilt on every change.

The effect's cleanup function sets map.current = null, so when these dependencies change, the cleanup runs and the guard condition (!map.current) becomes true again, causing the map to fully reinitialize rather than just re-running setup logic.

• position?.latitude and position?.longitude: A separate effect already handles position updates properly (lines 541-544). Including them here is redundant and causes map destruction/recreation on every prop change.
• mapData.cameraState: Updates frequently on every moveend event (line 412), triggering reinitializations during normal map interaction. The initial effect only needs to read it once; it should not be a dependency.

Only callbacks that are called during setup should be dependencies. Remove position properties and cameraState from the dependency array.

🤖 Prompt for AI Agents

In `@components/map/mapbox-map.tsx` at line 471, The map initialization effect is
re-running and tearing down the map because it lists mapData.cameraState and
position?.latitude/position?.longitude as dependencies; since the effect's
cleanup sets map.current = null this causes full reinitialization on every
camera or position update. Fix by removing mapData.cameraState and
position?.latitude and position?.longitude from the dependency array of the
effect (keep only setup callbacks like setMap, setIsMapLoaded, captureMapCenter,
handleUserInteraction, stopRotation), so the map is initialized once and
position/camera updates are handled by their dedicated effects.

[ngoiyaeric]

Closing this pull request as part of a bulk cleanup of pending PRs.

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

[charliecreates]

Reopened state inspected. The branch currently conflicts with main and is 185 commits behind it; the reopen did not include new commits or a review request. Please rebase or merge main, resolve the conflicts, and rerun checks first. Once the updated head is pushed, request review so the existing unresolved feedback can be reassessed against the current diff.