Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Query Doctor Analysis
10 queries analyzed
2 pre-existing issues
SELECT "guests"."id", "guests"."session_id", "guests"."username", "guests"."avatar_path", "guests"."color", "guests"."side", "guests"."audio_recording_path", "guests"."audio_recording_public", "gue...
indexassets(event_id, uploader_id, inserted_at desc)
cost 15,922 → 1,639 (90% reduction)SELECT * FROM guest_ip_addresses WHERE ip_address = '127.0.0.1';
indexguest_ip_addresses(ip_address)
cost 126 → 9 (93% reduction)
Using assumed statistics (10000 rows/table). For better results, sync production stats.
veksen
force-pushed
the
veksen/fix-pr-query-count
branch
from
77bc309 to
b999002
Compare
Move queryStats.total++ past all early-return filters (ignored,
introspection, duplicate, catalog) so it reflects the actual number
of unique queries analyzed — not the raw log entry count.
This fixes the mismatch between the PR comment ("X queries analyzed")
and the app's query list without needing a post-hoc patch in main.ts.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
veksen
force-pushed
the
veksen/fix-pr-query-count
branch
from
b999002 to
511b699
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PR comment showed the raw pgbadger log entry count (
queryStats.total) instead of the deduplicated/filtered query count, causing a mismatch — e.g. "28 queries analyzed" while the app showed "Queries (5)".Root cause:
queryStats.total++was at the top ofprocessQuery(), counting every log entry — including ignored, introspection, duplicate, and catalog queries that get filtered out.Fix: Move
queryStats.total++to after all early-return filters so it only counts queries that actually get analyzed. No post-hoc patching needed.Test plan
queryStats.totalas the query count (with and without comparison)buildQueriescorrectly filters invalid results and ignored hashes🤖 Generated with Claude Code