fix(ci): pass WF_GITHUB_TOKEN to checkout for git fetch and PR creation#97
Open
davidoliv1 wants to merge 1 commit into
Open
fix(ci): pass WF_GITHUB_TOKEN to checkout for git fetch and PR creation#97davidoliv1 wants to merge 1 commit into
davidoliv1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WF_GITHUB_TOKENto theactions/checkoutstep in the S3 multi-environment deploy workflowMotivation
Steps that run
git fetch origin main stageandgh pr createneed a checkout with credentials that can access the repository. The defaultGITHUB_TOKENmay be insufficient for cross-branch git operations and PR creation in reusable workflows.Changes
with.token: ${{ secrets.WF_GITHUB_TOKEN }}to the Checkout step inbuild_and_upload_to_s3Test plan
create_pr_in_main: trueon a consumer repogit fetch origin main stagesucceeds in the workflow logsstagetomainworks when conditions are met