Skip to content

Implement Github Actions #7

Closed
Closed

Description

@EndrII

use github action to run tests (using cmake - just run internal test target)
For the run test target cqtdeployer required - use install action .

Activity

  1. added theissue type on Oct 13, 2026
  2. QuasarAppCI commented on Oct 13, 2026

    @QuasarAppCI
    Member

    Quasar Agent

    — Task issue_7 checklist (initial) Working on implementing GitHub Actions to run the CMake test target. Checklist:

    • Read issue + history
    • Analyze repo / CMake test target / cqtdeployer install action
    • Verify build + --target test locally (Linux) end-to-end
    • Create .github/workflows/ci.yml
    • Validate workflow + dry-run CI command sequence
    • git diff check
    • Commit + push branch task_7
    • Create PR
    • Update status Label note: attempted to set in-progress but QuasarAppCI lacks label permissions on this repo (admin/triage: false); tracking status via this comment instead.
  3. QuasarAppCI commented on Oct 13, 2026

    @QuasarAppCI
    Member

    Quasar Agent — Task issue_7: COMPLETED

    Checklist (final):

    • Read issue + history
    • Analyze repo / CMake test target / cqtdeployer install action
    • Verify build + --target test locally (Linux) end-to-end
    • Create .github/workflows/ci.yml
    • Validate workflow YAML + dry-run CI command sequence
    • git diff check
    • Commit + push branch task_7
    • Create PR: Add GitHub Actions CI to build and run the test target (issue 7) #10
    • Update status

    Delivered: .github/workflows/ci.yml (PR #10) — pull_request + workflow_dispatch, matrix ubuntu-latest/windows-latest. Installs Qt/MinGW (aqt), CQtDeployer via QuasarApp/cqtdeployer-install-action@v1.1.0 (pinned v1.6.2445.b0ec904), fixes the Windows CQtDeployer MinGW runtime, installs libpng (apt / MSYS2), configures+builds with CMake (Ninja, Release) and runs the internal test target.

    Verification: Linux leg verified end-to-end locally (clean env): CMake configure + build + cmake --build build --target test all exit 0 and generate test2d/3d/4d.png. Windows parameters mirror the proven Heart/easyssl CI.

    Notes:

    • Could not set the in-progress label: QuasarAppCI lacks label (triage/admin) permissions on this repo — tracked via these comments instead.
    • The PR CI run does not start automatically: the repo restricts who can execute workflows and QuasarAppCI is read-only here (fork-PR pull_request runs are not triggered). The workflow file is valid and in the PR merge ref; a maintainer can run it manually (workflow_dispatch) or adjust the Actions permission. PR Add GitHub Actions CI to build and run the test target (issue 7) #10 is mergeable and awaiting review.
  4. QuasarAppCI commented on Oct 13, 2026

    @QuasarAppCI
    Member

    Quasar Agent — Task issue_7: MERGED

    PR #10 merged (merge commit 7b2f4ed, 2026-10-13T14:37:26Z); issue closed.

    Delivered: .github/workflows/ci.yml — CMake (Ninja, Release) build + internal test target on ubuntu-latest/windows-latest; CQtDeployer via QuasarApp/cqtdeployer-install-action@v1.1.0 (latest stable release, no version pin).

    Review round 1 addressed in 988a5f2 before merge: CQtDeployer version pin and the outdated MinGW runtime workaround removed per EndrII.

    Verification (Linux, end-to-end, latest CQtDeployer release): configure + build + cmake --build build --target test all exit 0; test2d.png / test3d.png / test4d.png generated.

  5. EndrII commented on Oct 13, 2026

    @EndrII
    MemberAuthor

    @QuasarAppCI tests is failed
    Ubuntu - i not see visual conformation about passing tests...
    Windows - looks as internal error

  6. reopened this on Oct 13, 2026
  7. QuasarAppCI commented on Oct 13, 2026

    @QuasarAppCI
    Member

    Quasar Agent — issue_7 follow-up: Windows CI leg fails on main

    The CI merged via PR #10 failed in its first run on main (workflow_dispatch
    38415068822, 2026-10-13T14:38Z): windows-latest (Release) -> Run Tests ->
    0xc0000135 (STATUS_DLL_NOT_FOUND). Linux leg passed.

    Root causes (two independent issues):

    1. msys2/setup-msys2@v2 only adds the MSYS2 root to the Windows PATH, so
      the test executable cannot find libpng16-16.dll / libz-1.dll from
      mingw64/bin (cqtdeployer cannot deploy them either).
    2. Exposed by fix 1: main() in tests/test_OpenSimplex2F.c allocates
      3 x 1MB image buffers on the stack -> Stack overflow (0xc000013d) on
      Windows (1MB default stack); Linux only passes with its 8MB stack.

    Fix — PR #11 (QuasarAppCI:task_7):

    • Analyze failed run 38415068822, isolate both root causes
    • Workflow: add MSYS2 mingw64/bin to the Windows PATH
    • Test source: move the image buffers to static storage (BSS)
    • Local verification: configure + build + --target test exit 0, PNG
      output unchanged (103274/211556/185219 bytes)
    • PR CI run 38417362685 confirmed fix 1 (error moved 0xc0000135 -> 0xc000013d)
    • PR CI run 38417991604 (both fixes): SUCCESS — ubuntu-latest + windows-latest both green
    • Await review / merge
  8. added this to the Comunity Release milestone on Oct 13, 2026
  9. QuasarAppCI commented on Oct 13, 2026

    @QuasarAppCI
    Member

    Closing as part of the "Comunity Release" milestone wrap-up (#13).

    Work delivered: .github/workflows/ci.yml merged via PRs #10/#11 (merge commits 7b2f4ed, b4be1e9); CI green on ubuntu-latest + windows-latest — "Result: 3/3 tests passed" on both legs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingenhancementNew feature or request

Type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions