Skip to content

fix: fall back to default DNS resolver when system config is unparseable #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n13 merged 2 commits into from
Jul 1, 2026
Merged

fix: fall back to default DNS resolver when system config is unparseable #613

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee6e0f8
fix: fall back to default DNS resolver when system config is unparseable
n13 Jul 1, 2026
3e39d41
defautl to google DNS like previous hickory versions
n13 Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions client/litep2p/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,10 @@ use crate::{
#[cfg(feature = "websocket")]
use crate::transport::websocket::WebSocketTransport;

use hickory_resolver::TokioResolver;
use hickory_resolver::{
config::{ResolverConfig, GOOGLE},
TokioResolver,
};
use multiaddr::{Multiaddr, Protocol};
use transport::Endpoint;
use types::ConnectionId;
Expand Down Expand Up @@ -155,8 +158,20 @@ impl Litep2p {
let mut listen_addresses = vec![];

let (resolver_config, resolver_opts) = if litep2p_config.use_system_dns_config {
hickory_resolver::system_conf::read_system_conf()
.map_err(|e| Error::CannotReadSystemDnsConfig(e.into()))?
// `ResolverConfig::default()` has no nameservers since hickory 0.26, so on a
// failed system read fall back to public DNS rather than leave the node unable
// to resolve `/dns/` peers.
match hickory_resolver::system_conf::read_system_conf() {
Ok(conf) => conf,
Err(error) => {
tracing::error!(
target: LOG_TARGET,
?error,
"failed to read system DNS config; falling back to public DNS",
);
(ResolverConfig::udp_and_tcp(&GOOGLE), Default::default())
},
}
} else {
(Default::default(), Default::default())
};
Expand Down
Loading