Skip to content

Conversation

@sanderdemeyer
Copy link
Contributor

This code is based on its (asymetric) implementation in TNRKit.jl TNRKit.jl, which was based on this paper.

This is definitely still a work in progress. Some major comments are in order.

  • There are many convention choices that are up for debate. I think the current choice for the order of the legs is a natural extension to the square case.
  • Naming conventions are also up for debate.
  • Not everything is as general as the square lattice case. E.g. some constructors can definitely still be improved.
  • There is no triangular PEPO constructor yet. I don't need it for this PR, so to make this PR somewhat manageable, I would prefer to keep it out for now and add it later when someone needs it.
  • There are some docstrings that need to be fixed. The definition of the triangular environment (which can be found in the paper) still needs to be drawn.
  • Maybe the most important comment of all is in terms of differentiability. The tests are currently failing for the differentiability part (as expected). I know that @pbrehmer was willing to help out for this. In any case, any help on this part would definitely be appreciated. If this would be fixed, we could also calculate the ground-state energy of some interesting model (which was the whole point of this PR), which could be used as a test.

This code is based on its (asymetric) implementation in TNRKit.jl, which was based on the paper https://arxiv.org/pdf/2510.04907
@kshyatt
Copy link
Member

kshyatt commented Jan 23, 2026

@sanderdemeyer maybe this would be a good forcing function for #323 ?

@codecov
Copy link

codecov bot commented Jan 23, 2026

@Yue-Zhengyuan
Copy link
Member

A suggestion for file names: I prefer ctmrg_environment_triangular etc so that when sorting files by name, same things for different lattices appear together (infinite_triangular_network is an exception because infinite_square_network existed).

@Yue-Zhengyuan Yue-Zhengyuan mentioned this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants