Add some tests for randomized SVD #159
Open
+19
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkdvos
reviewed
Jan 23, 2026
test/testsuite/svd.jl
Outdated
| minmn = min(m, n) | ||
| S₀ = collect(svd_vals(A)) | ||
| U1, S1, V1ᴴ, ϵ1 = @testinferred svd_trunc(A; alg) | ||
| @test collect(diagview(S1))[1:alg.k] ≈ S₀[1:alg.k] |
Member
There was a problem hiding this comment.
Overall looks good, but this alg.k kind of sticks out a bit, do we always expect this property to be available?
On a separate note, should we think about whether or not the svd_trunc should really just output an S of length k to begin with?
That way, we can simply do:
@test collect(diagview(S1)) ≈ S₀[axes(S1, 1)]
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
kshyatt
force-pushed
the
ksh/randomized_svd
branch
from
adb7cda to
3afd7bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitely open to feedback on this one but thought we should start testing this. Also simplified the implementation a bit to reduce repeated code.