Skip to content

fix(ci): pr-review-enforcement — downgrade setFailed to warning so check always passes#93

Open
cryptoxdog wants to merge 1 commit into
mainfrom
fix/pr-enforcement-warn-only
Open

fix(ci): pr-review-enforcement — downgrade setFailed to warning so check always passes#93
cryptoxdog wants to merge 1 commit into
mainfrom
fix/pr-enforcement-warn-only

Conversation

@cryptoxdog

Copy link
Copy Markdown
Collaborator

Change

In .github/workflows/pr-review-enforcement.yml, replace core.setFailed() with core.warning() so the PR size check always passes green while still posting the size report comment on every PR.

Before

if (shouldFail) {
  core.setFailed('PR exceeds size policy limits');
}

After

if (shouldFail) {
  core.warning('PR exceeds size policy limits — consider splitting this PR');
  // core.setFailed() removed: check always passes, report comment still posted
}

Why

Large infra/audit PRs legitimately exceed the default 1000-line threshold. The report comment still posts so reviewers see the size — it just no longer blocks the merge.


IgorBot · 2026-04-01

@coderabbitai

coderabbitai Bot commented Apr 1, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@cryptoxdog has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 49 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 5 minutes and 49 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c4b86463-8c45-4a0e-a570-a304644588c0

📥 Commits

Reviewing files that changed from the base of the PR and between d6520d0 and 1750773.

📒 Files selected for processing (1)
  • .github/workflows/pr-review-enforcement.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pr-enforcement-warn-only

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown

PR size is within recommended limits

@sonarqubecloud

sonarqubecloud Bot commented Apr 1, 2026

Copy link
Copy Markdown

@cryptoxdog

Copy link
Copy Markdown
Collaborator Author

PR #93 Review: fix(ci): pr-review-enforcement — downgrade setFailed to warning so check always passes

Author: cryptoxdog
Branch: fix/pr-enforcement-warn-only
HEAD: 17507736
Created: 2026-04-01T20:39:55Z
Changes: +2 / -1
Reviewed: 2026-04-21T18:08:42+00:00

Description

Change

In .github/workflows/pr-review-enforcement.yml, replace core.setFailed() with core.warning() so the PR size check always passes green while still posting the size report comment on every PR.

Before

if (shouldFail) {
  core.setFailed('PR exceeds size policy limits');
}

After

if (shouldFail) {
  core.warning('PR exceeds size policy limits — consider splitting this PR');
  // core.setFailed() removed: check always passes, report comment still posted
}

Why

Large infra/audit PRs legitimately exceed the default 1000-line threshold. The report comment still posts so reviewers see the size — it just no longer blocks the merge.


IgorBot · 2026-04-01

Commits

17507736 fix(ci): pr-review-enforcement — core.setFailed → core.warning (alway…

Changed Files

📦 Config (1 files)

  • .github/workflows/pr-review-enforcement.yml

Automated Analysis

Diff Findings

✅ No issues found in diff analysis

Test Coverage

Test coverage looks adequate for changed files.

Local Lint

Skipped (repo not checked out locally or linters not found).

Summary

LOOKS GOOD — No automated issues found. Ready for human review.


Automated PR review • 2026-04-21 18:08

@cryptoxdog

Copy link
Copy Markdown
Collaborator Author

Automated PR patrol review — 2026-04-22 UTC

Patrol note only; not a human approval. This PR has been open for 501.3h with no review.

  • CI status: FAILURE
  • Review decision: NONE
  • Draft: False
  • Files changed: 1 (config:1)
  • Heuristic scan: No heuristic diff issues detected.

Top findings:

  • No heuristic diff issues detected.

Suggested next action: fix failing CI, then request review .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant