fix: Preserve categorical categories in Arrow schema export - #405
Open
Oliver Borchert (borchero) wants to merge 1 commit into
Open
Oliver Borchert (borchero) wants to merge 1 commit into
Oliver Borchert (borchero) wants to merge 1 commit into
Conversation
Oliver Borchert (borchero)
requested review from
Andreas Albert (AndreasAlbertQC) and
Daniel Elsner (delsner)
as code owners
September 19, 2026 04:13
Copilot started reviewing on behalf of
Oliver Borchert (borchero)
September 19, 2026 04:13
View session
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 46 46
Lines 2616 2616
=========================================
Hits 2616 2616 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Only a minor test-structure nit remains, with no approval-blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Preserves categorical metadata in Polars and Arrow schema exports by updating fork pins and adding regression coverage.
Changes:
- Adds categorical schema preservation tests.
- Expands Arrow metadata coverage.
- Updates Polars dependencies and lockfile.
| File | Description |
|---|---|
tests/columns/test_polars_schema.py |
Adds categorical preservation tests. |
tests/columns/test_arrow_pycapsule.py |
Extends categorical Arrow metadata coverage. |
Cargo.toml |
Updates the Polars fork pin. |
Cargo.lock |
Refreshes locked dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pl.Schema(DataframelySchema)drops categorical names, namespaces, and physical types.Changes
Update the Polars fork pin to include pola-rs/polars#29385 and add a reminder to switch back once the fix is released.