-
Notifications
You must be signed in to change notification settings - Fork 0
[codex] Apply audit remediation #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main ] | ||
| pull_request: | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 20 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Resolve QuantPlatformKit ref | ||
| id: quant-platform-kit-ref | ||
| run: | | ||
| set -euo pipefail | ||
| ref="main" | ||
| if [ -n "${GITHUB_HEAD_REF:-}" ]; then | ||
| case "${GITHUB_HEAD_REF}" in | ||
| dependabot/*) | ||
| ;; | ||
| *) | ||
| if git ls-remote --exit-code --heads https://github.com/QuantStrategyLab/QuantPlatformKit.git "${GITHUB_HEAD_REF}" >/dev/null 2>&1; then | ||
| ref="${GITHUB_HEAD_REF}" | ||
| fi | ||
| ;; | ||
| esac | ||
| fi | ||
| echo "ref=${ref}" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Checkout QuantPlatformKit | ||
| uses: actions/checkout@v6 | ||
| with: | ||
| repository: QuantStrategyLab/QuantPlatformKit | ||
| ref: ${{ steps.quant-platform-kit-ref.outputs.ref }} | ||
| path: external/QuantPlatformKit | ||
|
|
||
| - name: Setup Python | ||
| uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: "3.11" | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| set -euo pipefail | ||
| python -m pip install --upgrade pip | ||
| python -m pip install -e . pandas pytest ruff | ||
| python -m pip install --no-deps -e external/QuantPlatformKit | ||
|
|
||
| - name: Run Ruff | ||
| run: | | ||
| set -euo pipefail | ||
| ruff check . | ||
|
|
||
| - name: Run unit tests | ||
| run: | | ||
| set -euo pipefail | ||
| PYTHONPATH=src python -m pytest -q tests | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked
python -m ruff check --help, which saysruff check [FILES]runs on the given files or directories and defaults to.. Because this workflow checks outQuantPlatformKitunderexternal/QuantPlatformKitbefore this step,ruff check .will also lint that external repository; any lint/config change there can fail HkEquityStrategies CI even when this repo's code is fine. Scope Ruff to the local paths, or excludeexternal/.Useful? React with 👍 / 👎.