Add execution report heartbeat alerts#60
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e25621c91a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if platform and not base.rstrip("/").endswith(f"/{platform}"): | ||
| base = f"{base}/{platform}" | ||
| for month in _month_segments(since, now): | ||
| globs.append(f"{base}/**/{month}/*.json") |
There was a problem hiding this comment.
Match the persisted month directory format
The default heartbeat glob is built with the raw month segment like 2026-06, but the strategy-run writer stores the period through safe_key(run_period), so the actual latest report path is under 2026_06/latest.json. With only FIRSTRADE_GCS_STATE_BUCKET / FIRSTRADE_STATE_PREFIX configured as documented, this glob never matches the persisted strategy-run JSON and the scheduled heartbeat will alert/fail even after a successful run.
Useful? React with 👍 / 👎.
Summary
Validation