[codex] Sync TQQQ risk diagnostics#116
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a8f37847d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "dual_drive_volatility_delever_enabled", | ||
| "dual_drive_volatility_delever_window", | ||
| "dual_drive_volatility_delever_threshold_mode", | ||
| "dual_drive_volatility_delever_threshold", |
There was a problem hiding this comment.
Preserve new fields from execution annotations
When a strategy supplies these new risk-control audit values under diagnostics["execution_annotations"] (the same normalized path this mapper already supports for signal_display, thresholds, benchmark values, etc.), they are dropped because the new pass-through list is only copied from top-level diagnostics in the loop below. In that scenario the TQQQ notification and signal snapshot never see dual_drive_volatility_delever_applied or its thresholds, so the risk-control line added in this commit is silently omitted; check execution_annotations as a fallback for these fields or include them in the execution-field mapping.
Useful? React with 👍 / 👎.
Summary
Validation