Repository navigation
feature: read the Docker client timeout from DOCKER_CLIENT_TIMEOUT - #716
Open
Amadeus-22 wants to merge 1 commit into
Open
Amadeus-22 wants to merge 1 commit into
Amadeus-22 wants to merge 1 commit into
Conversation
The Docker SDK's default timeout of 60 seconds is too short for some Docker hosts. DOCKER_CLIENT_TIMEOUT, the variable Docker Compose reads for the same purpose, now sets the timeout of the client the CLI creates. When it is not set, the SDK default is used as before, and a value that is not a positive whole number of seconds is reported instead of being silently ignored. Closes QuantConnect#364 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #364
Description
The Docker client the CLI creates uses the SDK's default timeout of 60 seconds, which is too short for some Docker hosts. There was no way to change it.
DockerManagernow readsDOCKER_CLIENT_TIMEOUT, the same variable Docker Compose uses for this, and passes it to the client. When it is not set or empty, the SDK default is used as before. A value that is not a positive whole number of seconds raises a clear error instead of being silently ignored.How Has This Been Tested?
tests/components/docker/test_docker_manager.py: default timeout when the variable is unset or empty, the value passed to the client when set, and an error for invalid values (parametrized).🤖 Generated with Claude Code