Repository navigation
fix: preserve HTML when exporting report PDF - #715
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #714
The PDF export uses a case-sensitive string replacement of
.html. Uppercase or missing extensions therefore make the PDF copy overwrite the HTML; repeated.htmlsegments also change more than the final suffix.Use
Path.with_suffix(".pdf")to derive the PDF filename. When the HTML destination already has a.pdfsuffix (case-insensitive), append.pdfso both outputs remain separate, including on case-insensitive filesystems.Tests
Parameterized CLI tests inspect both export commands for lowercase and uppercase HTML extensions, no extension, repeated
.htmlsegments, and lowercase/uppercase PDF destinations. The report test module had 5 failures and 58 passes before the fix, and 63 passes afterward. Docker is mocked; no full report-engine run was performed.AI assistance was used to prepare this change and its tests.