Retain live statistics samples through chart trimming#9491
Open
stoicAI1776 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9477.
Live chart trimming keeps streamed/displayed charts bounded to the recent window, but statistics were generated from those same trimmed series. After a few days, daily
ReturnandBenchmarksamples could be trimmed down to too few points, causing PSR and related live-mode risk metrics to collapse to defaults.This change keeps a small live-only retention buffer for the daily statistics inputs and merges those retained samples into the chart clones used for statistics generation. The visible/live chart trimming path remains unchanged.
Changes
BaseResultsHandler.GenerateStatisticsResults(Dictionary<string, Chart>, ...)virtual so live results can prepare statistics inputs before delegating.Strategy Equity / EquityStrategy Equity / ReturnBenchmark / BenchmarkPortfolio Turnover / Portfolio TurnoverTesting
git diff --checkdotnet test Tests\QuantConnect.Tests.csproj --filter RetainsDailyStatisticsSamplesAfterChartTrimming --no-restore --logger "console;verbosity=minimal"dotnet build Tests\QuantConnect.Tests.csproj --no-restore -v:minimal /m:1 /nr:false