Conversation
What: - `latest` reserved on every git commit input: `--commit-id` (application deploy/redeploy, lifecycle deploy, cronjob deploy, terraform plan/plan_and_apply/force_unlock/migrate_state), `--chart_git_commit_id` (helm deploy), and `name:latest` in `environment deploy` --applications/--lifecycles/--cronjobs/--helms. CLI resolves newest commit of service branch, prints resolved SHA, deploys it. - `application redeploy --commit-id` honored. Flag declared but ignored before, redeploy always reused deployed commit. - `environment deploy --helms` fixed: passed helm name where helm id expected, so every call 404'd. Why: - Only explicit SHA before. Omitted flag redeploys already-deployed commit. No way to say "ship tip of branch", so CI resolved SHA itself: local checkout or hand-rolled API call. Notes: - Newest picked by `created_at`, not list position: API documents no order. - Resolution runs before any deploy request. Multi-service command with one unresolvable service aborts with nothing queued. `DeployTerraforms` non-batch path split into resolve pass then execute pass for same reason. - Image tags and chart versions never intercepted, `latest` stays verbatim. - `latest` rejected on `--values_override_git_commit_id`: no API lists commits of values-override repo. - `environment deploy` branches on source kind (`GetJobDocker`, `GetGitSource`), not on presence of a deployed commit, else never-deployed git service drops the version silently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
latestreserved on every git commit input:--commit-id. CLI resolves newest commit of service branch, prints resolved SHA, deploys it.application redeploy --commit-idhonored. Flag declared but ignored before, redeploy always reused deployed commit.environment deploy --helmsfixed: passed helm name where helm id expected, so every call 404'd.Why:
Notes:
created_at, not list position: API documents no order.DeployTerraformsnon-batch path split into resolve pass then execute pass for same reason.lateststays verbatim.latestrejected on--values_override_git_commit_id: no API lists commits of values-override repo.environment deploybranches on source kind (GetJobDocker,GetGitSource), not on presence of a deployed commit, else never-deployed git service drops the version silently.Summary by cubic
Adds
latestas a reserved commit id everywhere service commit ids are accepted (--commit-id, helm's--chart_git_commit_id, andname:latestinenvironment deployservice lists), so those inputs now deploy the newest commit of the service branch.application redeploy --commit-idis now honored instead of ignored, andenvironment deploy --helmsno longer 404s because it passed the helm name where the helm id was expected.Behavior changes
latestpicks the newest commit bycreated_at, not by list position, and prints the resolved SHA before deploying.latestis rejected on--values_override_git_commit_idbecause the API exposes no commit list for values-override repositories.latesttag or chart version is unaffected.Deploy notes
environment deploynow checks job and helm source kind instead of whether a deployed commit exists, so never-deployed git services don't drop their version silently.Written for commit 1166f85. Summary will update on new commits.