fix(chat): refresh external context on nested folder re-selection - #34
Open
luoxuanzao wants to merge 1 commit into
Open
fix(chat): refresh external context on nested folder re-selection#34luoxuanzao wants to merge 1 commit into
luoxuanzao wants to merge 1 commit into
Conversation
Re-selecting a folder in the external context picker that nests inside (or contains) an existing entry previously showed a conflict Notice and left the list unchanged, which read as 'the workspace folder never updates'. The picker now applies refresh semantics: conflicting entries are replaced by the new pick (persistence inherited from a replaced locked entry), with a 'Replaced X with Y' Notice. Unrelated folders still append and exact duplicates are still rejected. Co-authored-by: QoderAI (Qwen 3.8 Max) <qoder_ai@qoder.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExternalContextSelector.openFolderPicker).Cannot add ...Notice and left the list unchanged.Replaced "X" with "Y"Notice; persistence (lock) is inherited when a replaced entry was persistent. Unrelated folders still append; exact duplicates still rejected with the existing Notice.findAllConflictingPaths()insrc/core/context/external-context.tsand 5 picker tests (electron remote dialog mocked).Verification
npm run typechecknpm run lintnpm run test(3354 passed, incl. 5 new picker cases)npm run buildnpm run release:checknpm run audit:prod(unchanged deps; ran on sibling branch this week).../50-素材→ re-select parent.../testObsidian→ entry replaced, NoticeReplaced ~/Documents/testObsidian/50-素材 with "~/Documents/testObsidian"Safety
CHANGELOG.md