Expand "monitor and cancel a job" - #5240
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
One or more of the following people are relevant to this code:
|
|
@abbycross any updates on this? |
|
Ready for another round of reviewing @jyu00! |
jyu00
left a comment
jyu00
left a comment
There was a problem hiding this comment.
One minor comment, but this looks good!
Co-Authored-By: Jessie Yu <jessieyu@us.ibm.com>
beckykd
left a comment
beckykd
left a comment
There was a problem hiding this comment.
Lots of good information! Thanks!
| " - **Failed**: Job encountered an error\n", | ||
| " - **Canceled**: User canceled the job\n", | ||
| "\n", | ||
| " Click on the job name or row to open the detailed view. In the details panel, you can see:\n", |
There was a problem hiding this comment.
| " Click on the job name or row to open the detailed view. In the details panel, you can see:\n", | |
| " Click on the job name or row to open the detailed view. In the details panel, you can see the following:\n", |
There was a problem hiding this comment.
For translation, the intro to lists should be a complete sentence.
Also, I'm not sure about listing all of the things you can see in the detailed view. If the UI changes, it becomes incorrect. Also, if they can see it all by opening it, why list it all? If there are more important things to mention, you could put it in a list. For example "In the details panel, you can see information such as the results and any error messages."
That being said, it's not going to die on that hill :)
Co-authored-by: Rebecca Dimock <66339736+beckykd@users.noreply.github.com>
4 participants
Closes #4722