fix: avoid duplicate originals in augment_text_with_ids - #842
Open
emecii wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Summary
Fixes
Augmenter.augment_text_with_ids()returning every original input twice. The method appended the source text before augmentation and then appended it again alongside the generated variants, which silently over-represented originals in the returned training data.Additions
Changes
Deletions
list.extendattribute access.Validation
pytest tests/test_augment_api.py -k 'not back_translation and not back_transcription' -q— 12 passed, 2 model-dependent tests deselected.black --check,isort --check-only, andflake8on the changed files — passed.AI assistance
This PR was prepared with AI assistance. The behavior and regression test above were verified locally.
Checklist