fix: accept zero WordEmbeddingDistance thresholds - #841
Open
emecii wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Summary
This fixes
WordEmbeddingDistanceso that0.0is treated as an explicitly selected threshold rather than as an omitted value.Additions
Changes
Nonechecks when validating the mutually exclusivemin_cos_simandmax_mse_distoptions.0.0.0.0is a meaningful boundary: cosine similarity must be non-negative, and MSE distance must be zero. The previous truthiness checks rejected those constructor calls and would have skipped enforcement if accepted.Deletions
Validation
python -m pytest tests/test_word_embedding.py -k word_embedding_distance -q— 5 passedpython -m pytest tests/test_constraints -q— 8 passedmake lint— passedThe full
tests/test_word_embedding.pyrun was not used as the acceptance check because an existing network-backed embedding test stalled while downloading its artifact; the deterministic selected tests completed normally.Checklist