Make the default the dashboard's light, not the system's - #81
Merged
Merged
Conversation
I unified the two looks toward the wrong one. souta asked for the folder pages to be brought to the dashboard's look; what shipped brought the dashboard to the folder's, so choosing a dark scheme turned everything dark including the page that had been the reference. The theme stays -- seventeen schemes and the picker are not the problem. What changes is which one you get without choosing: base16's reference light, which reproduces what these pages looked like before any of them were themed. Its `base01` is `#e8e8e8` against the `#e3e3e3` the dashboard drew borders in, so a card still has an edge; `github` was closer on background and would have put `#f6f8fa` borders on a white page, which is no border at all. Compared by rendering the three light candidates rather than by reading hex. `auto` was the default and was also the *name* of the entry that follows the system -- one string doing two jobs, which only worked while they were the same idea. The moment the default became a real scheme the list had two entries called `default-light`. `theme_names_are_unique` failed, which is what a test that counts is for. `auto` has its own constant now and is still in the picker. Two more tests were right to fail. `css_for` fell back to the system pair for an unknown name, which was "the default" only while the default followed the system; it now falls back to the default itself, looked up rather than recursed into. And a test named `the_default_carries_a_light_and_a_dark_palette` was making a claim about `auto` under the default's name -- the same confusion, one layer up. This changes nothing for anyone who has already chosen: a remembered theme still wins, which is why souta's own daemon stays on catppuccin-mocha until they pick otherwise. Signed-off-by: Souta <shimozono-sota631@g.ecc.u-tokyo.ac.jp>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I unified the two looks toward the wrong one. souta asked for the folder pages to be brought to the dashboard's look; what shipped brought the dashboard to the folder's, so choosing a dark scheme turned everything dark — including the page that had been the reference.
The theme stays. Seventeen schemes and the picker were never the problem. What changes is which one you get without choosing.
Which light
Compared by rendering the three light candidates, not by reading hex:
githubmatches the background exactly and then puts#f6f8faborders on a white page, which is no border at all — base16 mapsbase01to both--hoverand--line, and the dashboard had those as different colours.default-light's#e8e8e8against the old#e3e3e3keeps a card's edge.autowas doing two jobsIt was the default and the name of the entry that follows the system. That worked only while they were the same idea. The moment the default became a real scheme the list had two entries called
default-light, andtheme_names_are_uniquefailed — which is what a test that counts is for.autohas its own constant now and is still in the picker.Two more tests were right to fail:
css_forfell back to the system pair for an unknown name. That was "the default" only while the default followed the system; it now falls back to the default itself, looked up rather than recursed into.the_default_carries_a_light_and_a_dark_palettewas making a claim aboutautounder the default's name — the same confusion, one layer up.For anyone who has already chosen
Nothing changes. A remembered theme still wins, which is why souta's own daemon stays on
catppuccin-mochauntil they pick otherwise.230 tests, 65 e2e checks against a real host, fmt/clippy clean.