fix: verify MQTT connection requires successful subscription#858
Merged
allenporter merged 3 commits intoJul 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes MQTT connection status reporting in V1Channel so is_mqtt_connected is only True when the MQTT session is connected and the channel has successfully established an MQTT subscription to the device topic, aligning status behavior with the referenced Home Assistant issue.
Changes:
- Update
V1Channel.is_mqtt_connectedto require a successful MQTT subscription (tracked via_mqtt_unsub) in addition to an active MQTT session. - Add tests covering MQTT subscription failure with local fallback success, and the case where both local and MQTT connection paths fail.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
roborock/devices/rpc/v1_channel.py |
Tightens MQTT “connected” status to reflect successful subscription establishment. |
tests/devices/rpc/test_v1_channel.py |
Adds regression tests to validate MQTT subscription failure handling and fallback behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lash-L
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MQTT connection status reporting by ensuring
is_mqtt_connectedis only True when the MQTT session is active AND the subscription to the device's topic has succeeded.References home-assistant/core#159609 (comment)