Skip to content

Fixing bug in piecewise/factorable with math domain and range error, plus named expressions - #4039

Draft
stephenscini wants to merge 14 commits into
Pyomo:mainfrom
stephenscini:factorable_expression_fix_SSC
Draft

stephenscini wants to merge 14 commits into
Pyomo:mainfrom
stephenscini:factorable_expression_fix_SSC

Conversation

@stephenscini

@stephenscini stephenscini commented Sep 11, 2026

Copy link
Copy Markdown
Member

Fixes # .

  • Makes devel/initialization bound_variables function more robust, fixes math domain and math range errors in factorable.py, and changes handling of named expressions.

Summary/Motivation:

In attempts to use devel/initialization with PROMMIS models, ran into issues related to named expressions, and with functions causing math domain or math range errors.

Changes proposed in this PR:

AI-Use Disclosure

  • AI tools were NOT used during the preparation of this PR

or

  • AI tools contributed to the development of this PR

    • AI tools generated documentation (including the PR description/comments, code comments, and/or Sphinx documentation)
    • AI tools generated tests (baselines, examples, and/or code)
    • AI tools generated code (apart from tests)

    Review process (select ONE):

    • Rewritten: All AI-generated content was rewritten by me before being committed.
    • Reviewed/verified: I retained AI-generated content and verified it before committing. Verification included (as applicable):
      • Ran the code and fixed issues
      • Added and ran tests
      • Checked correctness/logic of code and tests
      • Checked for alignment with the contribution guide
      • Considered security implications
    • As-is: AI-generated content was commited directly to the repository

Notes for reviewers (optional):

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants