Update (usage of) PyROS UncertaintySet validation routines - #4000
Open
shermanjasonaf wants to merge 15 commits into
Open
Update (usage of) PyROS UncertaintySet validation routines#4000shermanjasonaf wants to merge 15 commits into
UncertaintySet validation routines#4000shermanjasonaf wants to merge 15 commits into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
Following up on PRs #3558 and #3877, this PR modifies the (usage of) PyROS uncertainty set validation methods.
Changes proposed in this PR:
UncertaintySet.is_nonempty()call fromUncertaintySet.validate(). The call toUncertaintySet.is_nonempty()is considered redundant in the context ofPyROS.solve(), since PyROS already checks, outside ofUncertaintySet.validate(), the stricter criterion that the uncertainty set contains the user-provided nominal point.UncertaintySet.is_nonempty()always returns True if the uncertainty set is nonempty, even if the uncertainty set does not contain the user-provided nominal point (see Update PyROS Uncertainty Set Validation Methods #3558).is_nonempty()andis_bounded()methods forDiscreteScenarioSet.UncertaintySet.is_bounded(),UncertaintySet.is_nonempty(),UncertaintySet.validate(), andUncertaintySetsubclass instance validation routines.UncertaintySetbase class implementation.AI-Use Disclosure
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: