Skip to content

Update (usage of) PyROS UncertaintySet validation routines - #4000

Open
shermanjasonaf wants to merge 15 commits into
Pyomo:mainfrom
shermanjasonaf:pyros-uncertainty-set-validate
Open

Update (usage of) PyROS UncertaintySet validation routines#4000
shermanjasonaf wants to merge 15 commits into
Pyomo:mainfrom
shermanjasonaf:pyros-uncertainty-set-validate

Conversation

@shermanjasonaf

Copy link
Copy Markdown
Contributor

Summary/Motivation:

Following up on PRs #3558 and #3877, this PR modifies the (usage of) PyROS uncertainty set validation methods.

Changes proposed in this PR:

  • Remove UncertaintySet.is_nonempty() call from UncertaintySet.validate(). The call to UncertaintySet.is_nonempty() is considered redundant in the context of PyROS.solve(), since PyROS already checks, outside of UncertaintySet.validate(), the stricter criterion that the uncertainty set contains the user-provided nominal point.
  • Ensure that UncertaintySet.is_nonempty() always returns True if the uncertainty set is nonempty, even if the uncertainty set does not contain the user-provided nominal point (see Update PyROS Uncertainty Set Validation Methods #3558).
  • Fix the is_nonempty() and is_bounded() methods for DiscreteScenarioSet.
  • Update/extend documentation and testing of UncertaintySet.is_bounded(), UncertaintySet.is_nonempty(), UncertaintySet.validate(), and UncertaintySet subclass instance validation routines.
  • Simplify UncertaintySet base class implementation.

AI-Use Disclosure

  • AI tools were NOT used during the preparation of this PR

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@shermanjasonaf

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant