fix: remove internal use of deprecated role type methods

[Revnoplex]

Caution

Feature freeze is active, as described by our Release Schedule.

Summary

#2708 deprecated the use of certain role type methods (eg. Role.is_premium_subscriber) in favour of the RoleType enum. Now I found the library throwing several deprecation warnings when firing the on_guild_update event and upon tracing the lines the warnings were emitted from found several uses of the old methods. This pr replaces the found internal usage of these old methods.

Information

• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed).
• This PR is not a code change (e.g. documentation, README, typehinting,
  examples, ...).

Checklist

• I have searched the open pull requests for duplicates.
• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• If type: ignore comments were used, a comment is also left explaining why.
• I have updated the changelog to include these changes.
• AI Usage has been disclosed.
  • If AI has been used, I understand fully what the code does

[pycord-app]

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3167/head:pr-3167
git checkout pr-3167

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3167/head

[Paillat-dev]

My fault...

[Revnoplex]

I'm assuming I need a changelog entry this time as theres an entry for 2.8.0rc1 and the problem was introduced before this

[Soheab]

Should use is when comparing enums.

[Paillat-dev]

Yes needs a changelog as well.

Also please hold till I take a better look

[Revnoplex]

What testing needs to be done?

[Paillat-dev]

Not by you, I just wanna check that everything works as expected. hold: testing is there for other maintainers to signal to them to wait. Should all be alright though.

[Paillat-dev]

lgtm; tested; thanks for the pr !