Skip to content

CI/TST: Skip Matplotlib for cp315 Pyodide testing - #895

Merged
rgommers merged 3 commits into
PyWavelets:mainfrom
agriyakhetarpal:skip-matplotlib-cp315-pyodide
Nov 12, 2026
Merged

rgommers merged 3 commits into
PyWavelets:mainfrom
agriyakhetarpal:skip-matplotlib-cp315-pyodide

Conversation

@agriyakhetarpal

@agriyakhetarpal agriyakhetarpal commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

This PR should fix the failing Pyodide CI on main:

  • updates to cibuildwheel v4.3.5, which is recommended in light of the eMudhra incident
  • moves the cibuildwheel test settings for Pyodide into pyproject.toml and stops installing matplotlib for the cp315-pyodide_wasm32 tests, as Pyodide 315.0.0a2 does not provide a matplotlib build yet
    • I chose not to move the cibuildwheel configuration for Linux/macOS/Windows right now, in order to keep that separate from these changes, but I can do that in a follow-up PR if this is desirable. Please let me know! I usually tend to find cibuildwheel's configuration in pyproject.toml much more readable and centralised than environment variables spread across workflow files.

I'm working on getting a Pyodide 315.0.0a3 release out soon, and I will see if I can enable Matplotlib in there when I do so – after which we can remove the override.

Thank you!

@rgommers rgommers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green, let's give this a go. Thanks @agriyakhetarpal

And sure, a follow-up PR for moving other cibuildwheel config SGTM.

@rgommers
rgommers merged commit 5d84289 into PyWavelets:main Nov 12, 2026
20 checks passed
@agriyakhetarpal
agriyakhetarpal deleted the skip-matplotlib-cp315-pyodide branch November 12, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants