add HDPE water pipeline and water booster pump#277
Open
doneachh wants to merge 2 commits into
Open
Conversation
Author
|
Hi @euronion :) |
Collaborator
|
Yes, I'll review. Next time feel free to ping me with the PR as soon as you feel like it is ready for review. :) |
euronion
requested changes
Jun 11, 2026
euronion
left a comment
euronion
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution, see the comments below and let me know if you have any question!
|
|
||
| * The "currency_year" column will now reflect the inflation adjusted currency year instead of the original currency year of the input data. (https://github.com/PyPSA/technology-data/pull/275) | ||
|
|
||
| * Insert costs for water networks (https://github.com/PyPSA/technology-data/pull/277) |
Collaborator
There was a problem hiding this comment.
Suggested change
| * Insert costs for water networks (https://github.com/PyPSA/technology-data/pull/277) | |
| * Add cost assumptions for water network infrastructure: water pipeline HDPE and water pipeline booster pump (https://github.com/PyPSA/technology-data/pull/277) | |
That makes it clearer what technologies have been added
Comment on lines
+741
to
+743
| HDPE water pipeline,investment,2023,1588,EUR/(m^3-H2O/h)/km,2023,"HYPAT_WP_Water-Supply-for-Electrolysis-Plants, https://hypat.de/hypat-wAssets/docs/new/publikationen/HYPAT_WP_Water-Supply-for-Electrolysis-Plants.pdf -> Based on pipe diamter 171.65mm and 16 Bars with flow 34.71 kg/s. Considered mass flow rate for 1000 MW Electrolyzer",High-density polyethylene (HDPE) water pipeline cost | ||
| HDPE water pipeline,FOM,2023,5,%/year,2023,"HYPAT_WP_Water-Supply-for-Electrolysis-Plants, https://hypat.de/hypat-wAssets/docs/new/publikationen/HYPAT_WP_Water-Supply-for-Electrolysis-Plants.pdf", | ||
| HDPE water pipeline,lifetime,2023,50,years,2023,"HYPAT_WP_Water-Supply-for-Electrolysis-Plants, https://hypat.de/hypat-wAssets/docs/new/publikationen/HYPAT_WP_Water-Supply-for-Electrolysis-Plants.pdf", |
Collaborator
There was a problem hiding this comment.
-
Please rename it to "water pipeline HDPE", i.e. that the name reflects broader category -> diameter -> material details. So some of the info that you put in the details should also go into the name
-
Can you add the figure where you extracted the data from in the report? (Probably figure 4-7?) and the date when you accessed the publication.
-
The currency year should be 2022 instead of 2023, can you confirm/check?
-
Are there any insights about the technology year of this data, whether this is from 1981 (like the pump station data)? Else we can keep it as 2023
| HDPE water pipeline,investment,2023,1588,EUR/(m^3-H2O/h)/km,2023,"HYPAT_WP_Water-Supply-for-Electrolysis-Plants, https://hypat.de/hypat-wAssets/docs/new/publikationen/HYPAT_WP_Water-Supply-for-Electrolysis-Plants.pdf -> Based on pipe diamter 171.65mm and 16 Bars with flow 34.71 kg/s. Considered mass flow rate for 1000 MW Electrolyzer",High-density polyethylene (HDPE) water pipeline cost | ||
| HDPE water pipeline,FOM,2023,5,%/year,2023,"HYPAT_WP_Water-Supply-for-Electrolysis-Plants, https://hypat.de/hypat-wAssets/docs/new/publikationen/HYPAT_WP_Water-Supply-for-Electrolysis-Plants.pdf", | ||
| HDPE water pipeline,lifetime,2023,50,years,2023,"HYPAT_WP_Water-Supply-for-Electrolysis-Plants, https://hypat.de/hypat-wAssets/docs/new/publikationen/HYPAT_WP_Water-Supply-for-Electrolysis-Plants.pdf", | ||
| water booster pump,investment,2023,4775,EUR/kW,2023,"Calculated based on HYPAT_WP_Water-Supply-for-Electrolysis-Plants, https://hypat.de/hypat-wAssets/docs/new/publikationen/HYPAT_WP_Water-Supply-for-Electrolysis-Plants.pdf",Cost of water booster pump per horsepower |
Collaborator
There was a problem hiding this comment.
Similar points as for the technology above:
- rename to something like "water pipeline booster pump"
- Exact location where the info is taken from the publication (I couldn't locate the origin of the data from the pub)
- It seems like the publication uses a formula with a scaling exponent != 1, so if you make an assumption on the HP of the pump, add this assumptions and ideally also the calculation to the details.
- Check technology (1981?) and currency year (2022)
Comment on lines
+745
to
+746
| water booster pump,FOM,2023,2,%/year,2023,"HYPAT_WP_Water-Supply-for-Electrolysis-Plants, https://hypat.de/hypat-wAssets/docs/new/publikationen/HYPAT_WP_Water-Supply-for-Electrolysis-Plants.pdf", | ||
| water booster pump,lifetime,2023,30,years,2023,"HYPAT_WP_Water-Supply-for-Electrolysis-Plants, https://hypat.de/hypat-wAssets/docs/new/publikationen/HYPAT_WP_Water-Supply-for-Electrolysis-Plants.pdf", |
| water booster pump,investment,2023,4775,EUR/kW,2023,"Calculated based on HYPAT_WP_Water-Supply-for-Electrolysis-Plants, https://hypat.de/hypat-wAssets/docs/new/publikationen/HYPAT_WP_Water-Supply-for-Electrolysis-Plants.pdf",Cost of water booster pump per horsepower | ||
| water booster pump,FOM,2023,2,%/year,2023,"HYPAT_WP_Water-Supply-for-Electrolysis-Plants, https://hypat.de/hypat-wAssets/docs/new/publikationen/HYPAT_WP_Water-Supply-for-Electrolysis-Plants.pdf", | ||
| water booster pump,lifetime,2023,30,years,2023,"HYPAT_WP_Water-Supply-for-Electrolysis-Plants, https://hypat.de/hypat-wAssets/docs/new/publikationen/HYPAT_WP_Water-Supply-for-Electrolysis-Plants.pdf", | ||
| water booster pump,efficiency,2023,0.765,per unit,2023,"HYPAT_WP_Water-Supply-for-Electrolysis-Plants, https://hypat.de/hypat-wAssets/docs/new/publikationen/HYPAT_WP_Water-Supply-for-Electrolysis-Plants.pdf", No newline at end of file |
Collaborator
There was a problem hiding this comment.
Efficiency is not clear for this technology.
Minimum: Add to the details what the efficiency unit is
Ideally: Change the unit to something more clear, maybe m3 water per kWh or something?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
Changes proposed in this Pull Request
Adding costs for HDPE water pipelines and pumps -> needed for integration of desalination and water management in pypsa-earth
Checklist
doc.environment.yaml(if applicable).doc/release_notes.rstof the upcoming release is included.