Generate import libraries for free-threaded Python 3.13+ builds #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravenexp
force-pushed
the
python-313t
branch
from
b64dc7c to
c87052e
Compare
davidhewitt
reviewed
Nov 29, 2024
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks very much for the rapid turnaround! I think string flags is probably fine imo, both sysconfig and maturin just handle these as strings.
I was able to put together PyO3/pyo3#4749 to test this out downstream; I was able to reproduce a broken build and that this patch fixes it! 👍
Allow specifying the generated import library ABI flags as well as the interpreter version. Only `"t"` is currently supported as the ABI flags parameter value and only for CPython v3.13.
These require passing `abiflags="t"` to the generator.
ravenexp
force-pushed
the
python-313t
branch
from
c87052e to
c3a6098
Compare
Collaborator
Author
I've renamed the builder method and am going to merge this and release a new crate version after adding some more tests for Windows ARM64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python313t.dllfrom Windows CI builds.ImportLibraryGenerator::abi_tag()methodResolves #80