Conversation
5b1eb2b to
3f0814e
Compare
|
I'm having trouble building the |
8638c95 to
24e972d
Compare
Merging this PR will degrade performance by 11.18%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | into_i128_zero |
817.2 ns | 926.9 ns | -11.84% |
| ❌ | into_i128_small_pos |
932.8 ns | 1,042.5 ns | -10.52% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing Person-93:ffi-ptr-more-typesafe (25864be) with main (1655cdf)
Footnotes
-
6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
fc18b94 to
18197a2
Compare
8935abb to
25864be
Compare
|
These two feel ~similar in terms of how error prone and cluttered they feel. I'm not sure it's worth the churn. |
Objective
Simplify casting back and forth when unsafely converting raw pointers to pyo3 smart pointers. It's a bit error prone and makes the code appear very cluttered.
The public API of smart pointers is expanded as well. They can be unsafely created from any pointer which implementsFfiObjand theTparam is the associated `ApiObj.Changes
ApiObjandFfiObjFfiPtrExttrait for all*mut TwhereT: FfiObj