Skip to content

don't catch panics in no_std - #6434

Open
Person-93 wants to merge 3 commits into
PyO3:mainfrom
Person-93:no_std-traverse_panic_abort
Open

Person-93 wants to merge 3 commits into
PyO3:mainfrom
Person-93:no_std-traverse_panic_abort

Conversation

@Person-93

Copy link
Copy Markdown
Contributor

Feature-gate panic handing during gc traversal.

@codspeed

codspeed Bot commented Sep 18, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 13.62%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 2 regressed benchmarks
✅ 139 untouched benchmarks
⏩ 6 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
extract_biguint_small 1.4 µs 1.6 µs -13.85%
extract_biguint_zero 1.4 µs 1.6 µs -13.39%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing Person-93:no_std-traverse_panic_abort (af5fa82) with main (52a646f)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Person-93 Person-93 added no_std Require `no_std` builds to pass CI-skip-changelog Skip checking changelog entry labels Sep 19, 2026
@Person-93
Person-93 force-pushed the no_std-traverse_panic_abort branch 2 times, most recently from c2f52de to fe64f64 Compare September 19, 2026 03:39
@Person-93
Person-93 force-pushed the no_std-traverse_panic_abort branch from fe64f64 to af5fa82 Compare September 19, 2026 03:46

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry no_std Require `no_std` builds to pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant