bump GraalPy versions tested in CI, test graalpy on windows - #6406
davidhewitt wants to merge 8 commits into
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
|
@msimacek do you have any experience with pytest for GraalPy on windows? Looks like it's just exciting immediately with code 1 according to the CI log, I need to try to dig, not sure if you've seen similar before. |
|
pytest worked fine for me locally for this PR, but I also tried it on some other packages and ran into an issue that had the same symptom as yours. It could be worked around by turning off pytest's assertion rewriting (it's really weird that assertion rewriting would only be broken on windows, I'll need to look deeper into that). You can try if you get further with |
|
It looks like |
| )) | ||
| } else if abi.implementation == PythonImplementation::GraalPy { | ||
| // Similar for GraalPy on Windows, which ships `python-native.dll` | ||
| Ok("python-native".to_string()) |
There was a problem hiding this comment.
This also changes the library name when PYO3_USE_RAW_DYLIB=0. When my AI model tested, it broke graalpy because the library name is e.g. python312.lib but the build script requests python-native.lib anyway. I think this is correct only for PYO3_USE_RAW_DYLIB=1.
There was a problem hiding this comment.
xref #6410 (comment) - I guess it's the other side of the same hack, where a clause would be needed in that hack to also account for GraalPy.
I guess that means that only one of these PRs will merge successfully because #6410 introduces proper ffi-check for both modes of PYO3_USE_RAW_DYLIB.
I'll have a go at solving the full refactor properly, perhaps after merging #6410 but before merging here? Merging #6410 will unblock the rest of the expanded ffi-check testing in #6389
Having some pain over in
setuptools-rustin https://github.com/PyO3/setuptools-rust/actions/runs/34587139565/job/103223856532?pr=615 - hopefully bumping this fixes.