Conversation
davidhewitt
left a comment
There was a problem hiding this comment.
I think we should probably add an entry to the migration guide and make the deprecation message point at alternatives, so that users can have some guidance how to migrate.
|
The alternatives are added in #6382, I can add the migration guide after either this or that PR is merged, or as a separate PR. |
|
Sorry stated merging the wrong pr |
37fde0f to
ec557cf
Compare
ec557cf to
a989173
Compare
Merging this PR will regress 2 benchmarks
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | extract_biguint_small |
1.4 µs | 1.5 µs | -10.78% |
| ❌ | extract_biguint_zero |
1.4 µs | 1.6 µs | -10.41% |
| ⚡ | into_biguint_small |
1.5 µs | 1.3 µs | +16.79% |
| ⚡ | test_empty_class_init |
31.6 µs | 28.7 µs | +10.13% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing Person-93:deprecate-unsound-buffer-api (a989173) with main (5f3ea66)
Footnotes
-
6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
@davidhewitt, do you think the deprecation can be included in 0.29.3 ? Maybe the migration guide should be a separate PR that gets included in 0.30 when the functions are actually removed. |
Mark slice accessors of
PyBufferas deprecated. See #6267