No std bytes writer - #6251
Open
Person-93 wants to merge 13 commits into
Open
Conversation
Member
|
We currently do not expose The only usage is a Lines 160 to 171 in d5daa3d Should we expose PyBytesWriter directly or disable it completely until core has |
chirizxc
reviewed
Jul 27, 2026
Contributor
Author
I think it makes sense to expose it directly in that function. |
Person-93
force-pushed
the
no_std_bytes_writer
branch
from
July 30, 2026 01:30
6647d73 to
f37736f
Compare
Person-93
force-pushed
the
no_std_bytes_writer
branch
from
July 31, 2026 03:34
ba3470b to
013d76b
Compare
Person-93
force-pushed
the
no_std_bytes_writer
branch
from
July 31, 2026 05:22
013d76b to
f3656a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the WIP
no_stdsupport.I've made impl of
std::io::WriteforPyBytesWriterconditional onwip_feature_std. This makesPyBytesWritercompletely useless without the std feature, so I've added an additional methodwrite_bytes.