Avoid using PyDictObject when compiling for RustPython#6057
Open
bschoenmaeckers wants to merge 3 commits into
Open
Avoid using PyDictObject when compiling for RustPython#6057bschoenmaeckers wants to merge 3 commits into
PyDictObject when compiling for RustPython#6057bschoenmaeckers wants to merge 3 commits into
Conversation
davidhewitt
requested changes
May 26, 2026
Member
davidhewitt
left a comment
There was a problem hiding this comment.
Sorry for the slow review; I'm not sure this is enough:
- See e.g.
dict_lenfunction which assumes the layout ofPyDictObject; as long as the cast suceeds then this function is potentially wrong. Perhaps we should makePyDictObjectopaque (or not exposed at all) inpyo3-ffiunder RustPython? - I haven't checked extensively, but I have similar concerns for other types. e.g.
PyTupleMethods::as_slice.
26f0cab to
fef3a8c
Compare
Member
Author
RustPython will never support compiling without the abi3 feature enabled. So PyDictObject will never be available. I can look into enforcing the |
Member
Author
|
In 55c2ea9, I force enable the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6047
Tested using: