ci: check for fields potentially missing from structs in pyo3-ffi definitions#5918
Open
davidhewitt wants to merge 4 commits intoPyO3:mainfrom
Open
ci: check for fields potentially missing from structs in pyo3-ffi definitions#5918davidhewitt wants to merge 4 commits intoPyO3:mainfrom
pyo3-ffi definitions#5918davidhewitt wants to merge 4 commits intoPyO3:mainfrom
Conversation
davidhewitt
changed the title
tp_versions_used missing field in PyTypeObjectpyo3-ffi definitions
davidhewitt
changed the title
pyo3-ffi definitionspyo3-ffi definitions
Icxolu
reviewed
Mar 27, 2026
| pyo3-ffi = { path = "../../pyo3-ffi" } | ||
|
|
||
| [build-dependencies] | ||
| bindgen = "0.69.4" |
Member
There was a problem hiding this comment.
While we're here perhaps we also want to bump this to the lastest version.
Member
Author
There was a problem hiding this comment.
Good idea, will do so.
Member
Author
There was a problem hiding this comment.
I managed to run dependabot, not sure why that had been broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts
pyo3-ffi-checkto also be able to inspect the bindgen fields and test the full set of them, having done this I found no cases other than other than #5916 of structs having a correct size but missing a trailing field in the padding.