Run tests with macros and without experimental inspect#5913
Open
Run tests with macros and without experimental inspect#5913
Conversation
Tpt
force-pushed
the
tpt/tests-without-experimental-inspect
branch
from
a4a7225 to
dcdd176
Compare
We are currently not testing pyo3 with the `macros` feature enabled but without `full` enabled
Tpt
force-pushed
the
tpt/tests-without-experimental-inspect
branch
from
dcdd176 to
8089ba8
Compare
ngoldbaum
reviewed
Mar 26, 2026
| features += ",nightly" | ||
|
|
||
| return (None, "abi3", features, f"abi3,{features}") | ||
| return (None, "abi3", "macros", "abi3,macros", features, f"abi3,{features}") |
Contributor
There was a problem hiding this comment.
There's a trade-off that doing this will make CI more expensive. @davidhewitt do you happen to have context for why you excluded testing just the "macros" feature here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are currently not testing pyo3 with the
macrosfeature enabled but withoutfullenabled, i.e. with the default set of pyo3 featuresFixes Issue #5910