Skip to content

rework extract_argument code to populate holders as intermediate values#5742

Draft
davidhewitt wants to merge 13 commits intoPyO3:mainfrom
davidhewitt:extract-rework
Draft

rework extract_argument code to populate holders as intermediate values#5742
davidhewitt wants to merge 13 commits intoPyO3:mainfrom
davidhewitt:extract-rework

Conversation

@davidhewitt
Copy link
Copy Markdown
Member

This is an experiment to use type inference & "holders" to change the extract_argument code to no longer need to take &mut holder inputs to argument extraction but instead produce holders as outputs from extraction. The holders then have a subsequent "unpack" phase.

I think this might enable error messages for unimplemented PyFunctionArgument to look a bit nicer, I'm going to play with that shortly. Pushing now to see what the pipeline thinks.

Will update this PR with a more detailed description as the code takes shape...

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 19, 2026

Merging this PR will not alter performance

✅ 105 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing davidhewitt:extract-rework (b3368d0) with main (86c48d3)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant