Repository navigation
Show a Starting status from the click until the simulator is ready - #20
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After you launch the simulator nothing on the page said it was starting. Now a spinner and "Starting simulator…" appear beside the connect buttons, and the button pulses, from the click until the prompt is up. The sign clears when the boot fails as well. Other connection types show "Connecting…" once you have picked a device. The connect buttons still stay disabled until the page is ready.
Two browser tests: one checks the sign appears and then clears once the REPL prompt shows; one blocks the runtime and checks the sign appears and then clears after the failure. The first fails before this change and passes after.
Fixes #16