Skip to content

Desktop: attach check accepts the installers' semver form #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bdbarnett merged 1 commit into from
Oct 29, 2026
Merged

Desktop: attach check accepts the installers' semver form #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/desktop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,9 +324,11 @@ jobs:
shopt -s nullglob
files=(dist/*-setup.exe dist/*.deb)
[[ ${#files[@]} -eq 2 ]] || { echo "::error::expected two installers, found ${#files[@]}"; ls -l dist; exit 1; }
# Installers are named with the semver form: 0.1.5rc2 is 0.1.5-rc.2.
semver="$(sed -E 's/^([0-9]+\.[0-9]+\.[0-9]+)(a|b|rc)([0-9]+)$/\1-\2.\3/; s/^([0-9]+\.[0-9]+\.[0-9]+)\.dev([0-9]+)$/\1-dev.\2/' <<< "$version")"
for f in "${files[@]}"; do
[[ "$(basename "$f")" == *"$version"* ]] \
|| { echo "::error::$f does not carry version $version"; exit 1; }
[[ "$(basename "$f")" == *"$semver"* ]] \
|| { echo "::error::$f does not carry version $semver ($version)"; exit 1; }
done
ls -l "${files[@]}"
sha256sum "${files[@]}"
Expand Down
Loading