Repository navigation
Record a request in pins.json before it queues - #2
Merged
Merged
Conversation
…ed release can't be replaced and lost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A release request that waited behind a running build could be replaced by a later request, because GitHub's concurrency group keeps one pending run and a newer one replaces it. The release's pin was then never written to
pins.jsonand its packages missed the index.Now a
recordjob runs the moment a request arrives, outside the queue, and commits the pin to main (tools/pins.py record, which starts again from the remote'spins.jsonif another request's commit lands first). Only the build and the deploy queue. Every build checks out main when it starts, so a build that replaces a pending one still publishes the pending one's release.pins.jsonnow says what was requested rather than what is live, so a pin whose build fails stays there until it is fixed or replaced.tests/test_pins.pycoversapplyandrecordagainst a throwaway remote, including the stale-checkout and lost-push-race cases, and a new workflow runs it.