Repository navigation
audiograph: a TANH node - #332
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
TANHgraph node:TANH_LEVEL * tanh(TANH_DRIVE * x), x in units ofUNIT, using the graph's own tanh (the one the clipping two-poles use) so MicroPython, CircuitPython and CPython render the same bytes. It's on every target, including CircuitPython. Exposed in the MicroPython and CircuitPython bindings, the CPython extension andaudiograph.py, and documented in the audiograph reference.Tests (
tests/test_cpython_audiograph_nodes.py,Tanh) hold it to double-precision tanh within 1 count over drive and level settings, moving knobs and block sizes 32 to 256, and include a check that five wrong references (swapped gains, a clip, a rational approximation, drive off by 2 percent, level off by 1) fail the bar. CPython and MicroPython render the same 25,600 samples.