fix: do not add a blank line before async with - #372
Open
Johnkothapalli wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
async defrather than any indentedasyncstatement when classifying nested definitionsasync defbehaviorasync withdoes not gain a blank line after a function docstringFixes #351.
Validation
tox -e py314under Ubuntu/WSL — 241 unit tests passed (1 skipped), 271 integration tests passed (2 skipped), and 40 system tests passedpre-commitrelevant hooks — merge/TOML/YAML/debug checks, Black, isort, docformatter, Ruff, manifest validation, eradicate, and rstcheck passedgit diff --check— passedThe full lint workflow on upstream
masteris already red (run 31345372152) becauseCHANGELOG.mdis changed byend-of-file-fixer,_is_blank_linehas an existing D301 finding, andconfiguration.pyhas an existing MyPy assignment error. This patch does not change those lines or include their unrelated cleanup.AI assistance: Codex helped trace the classifier path and prepare the focused tests. The result was verified with the repository's Ubuntu tox gate above.